Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve interpolated string literals #114

Merged
merged 2 commits into from
Mar 23, 2019
Merged

Improve interpolated string literals #114

merged 2 commits into from
Mar 23, 2019

Conversation

arcticicestudio
Copy link
Contributor

Resolves #106

Improved the color for function braces in string templates to usenord6 instead of nord14. Also begin and end characters of an interpolated string literal ${} are now colorized as keyword (nord9) for better visual distinction.

Before

After

@arcticicestudio
Colorize interpolated string literal begin and end characters
24aefc0 
The begin and end characters of a interpolated string literal `${}` is
now colorized as keyword (`nord9`) for better visual distinction.

GH-106
@arcticicestudio
Adust color for function braces in string templates
a218f62 
Before this commit the braces of functions in string templates used the
color for strings. This has been improved to use `nord6` instead.

GH-106
@arcticicestudio arcticicestudio added this to the 0.8.0 milestone Mar 23, 2019
@arcticicestudio arcticicestudio self-assigned this Mar 23, 2019
@arcticicestudio arcticicestudio changed the title Improvement/gh 106 improve interpolated string literals Improve interpolated string literals Mar 23, 2019
@arcticicestudio arcticicestudio merged commit e13ded1 into develop Mar 23, 2019
@arcticicestudio arcticicestudio deleted the improvement/gh-106-improve-interpolated-string-literals branch March 23, 2019 19:44
@arcticicestudio arcticicestudio removed their assignment Mar 23, 2019
@arcticicestudio arcticicestudio mentioned this pull request Mar 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-syntax scope-compatibility scope-ux type-improvement
Projects
None yet
Milestone
version-0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @svengreb