Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code 1.13 workbench theme feature migration #25

Closed
39 tasks done
arcticicestudio opened this issue Jun 24, 2017 · 3 comments
Closed
39 tasks done

VS Code 1.13 workbench theme feature migration #25

arcticicestudio opened this issue Jun 24, 2017 · 3 comments
Labels
context-ui type-feature
Milestone
version-0.4.0

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jun 24, 2017 •
edited
Loading

VS Code 1.13 has been released including a bunch of new workbench theme features documented in the official Theme Color Reference.

Tasks

UI

Base Colors

  • errorForeground

Input Control

  • input.placeholderForeground

List and Trees

  • list.inactiveSelectionForeground
  • list.hoverForeground
  • list.focusForeground

Sidebar

  • sideBar.foreground
  • sideBar.border
  • sideBarSectionHeader.foreground

Editor Groups & Tabs

  • editorGroupHeader.tabsBorder
  • tab.unfocusedActiveForeground
  • tab.unfocusedInactiveForeground

Editor

Rulers

  • editorRuler.foreground

Code Lens

  • editorCodeLens.foreground

Bracket matches

  • editorBracketMatch.background
  • editorBracketMatch.border

Overview ruler

  • editorOverviewRuler.border

Gutter

  • editorGutter.background
  • editorGutter.modifiedBackground
  • editorGutter.addedBackground
  • editorGutter.deletedBackground

Editor Widgets

  • editorWidgetBorder

Peek View Colors

  • peekViewEditorGutter.background

Merge Conflicts

  • merge.currentHeaderBackground
  • merge.currentContentBackground
  • merge.incomingHeaderBackground
  • merge.incomingContentBackground
  • merge.border
  • editorOverviewRuler.currentContentForeground
  • editorOverviewRuler.incomingContentForeground

Status Bar Colors

  • statusBar.debuggingForeground
  • statusBar.noFolderForeground
  • statusBar.noFolderBackground
  • statusBar.border

Quick Picker

  • pickerGroup.border

Integrated Terminal Colors

  • terminal.background
  • terminal.foreground

Welcome Page

  • welcomePage.buttonBackground
  • welcomePage.buttonHoverBackground
  • walkThrough.embeddedEditorBackground
@arcticicestudio arcticicestudio added this to the 0.4.0 milestone Jun 24, 2017
@arcticicestudio arcticicestudio self-assigned this Jun 24, 2017
@ajitid
Copy link
Contributor

ajitid commented Jun 24, 2017 •
edited
Loading

One suggestion: Just to keep theme minimal, do not add terminal.background to it.

@arcticicestudio
Copy link
Contributor Author

Currently the terminal uses the editor background color by default, terminal.background will be assigned to it too. Visually nothing will change, but the theme should include the selector just for completeness and to prevent side effects when the VS Code team decides to change the default values like they did to some settings in version 1.13.

arcticicestudio added a commit that referenced this issue Jun 25, 2017
@arcticicestudio
GHI-#25 Implement new VS Code workbench theme API features
2317a28
arcticicestudio added a commit that referenced this issue Jun 25, 2017
@arcticicestudio
GHI-#25 Remove duplicate selector
bc02c97
arcticicestudio added a commit that referenced this issue Jul 1, 2017
@arcticicestudio
GHI-#25 Use nord7 for incoming merge conflicts
d380c08
@arcticicestudio arcticicestudio mentioned this issue Jul 1, 2017
Merged
arcticicestudio referenced this issue Jul 1, 2017
@arcticicestudio
Merge pull request #27 from arcticicestudio/feature/ghi-#25-vs-code-1…
6aff96b 
….13-workbench-theme-feature-migration

VS Code 1.13 workbench theme feature migration
@arcticicestudio
Copy link
Contributor Author

🚢 Shipped with extension release version 🏷 0.4.0.

@arcticicestudio arcticicestudio removed their assignment Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-ui type-feature
Projects
None yet
Milestone
version-0.4.0
Development

No branches or pull requests
2 participants
@arcticicestudio @ajitid