Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More theme improvements #24

Closed
ajitid opened this issue Jun 11, 2017 · 4 comments
Closed

More theme improvements #24

ajitid opened this issue Jun 11, 2017 · 4 comments

Comments

@ajitid
Copy link
Contributor

ajitid commented Jun 11, 2017

Colors of these can also be changed

screenshot 105

  • BG/FG color of that Total 494 settings: colored with "badge.background" and "badge.foreground"
  • Line below User Settings

screenshot 104

  • Color of the seperator (between Monokai Dimmed and Install Additional Color Themes)
@arcticicestudio arcticicestudio added this to the 0.4.0 milestone Jun 24, 2017
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jun 24, 2017

Thanks for this nice summary of new workbench features 👍
It really helps a lot (especially the screenshots) if one maintains a lot of port projects for applications I'm not using on my own.
I've added this issue to the 0.4.0 project board and milestone.

Tasks

Workbench

Base Colors

  • selection.background

Progress Bar

  • progressBar.background

Extensions

  • extensionButton.prominentForeground
  • extensionButton.prominentBackground
  • extensionButton.prominentHoverBackground

Badge

  • badge.foreground
  • badge.background

Editor

Errors and Warnings

  • editorError.foreground
  • editorError.border
  • editorWarning.foreground
  • editorWarning.border

TODO

  • Determine whether the separator line of the command bar (Quick Open) is customizable.
    ➡️ Controlled by the pickerGroup.border selector

Line below User Settings

@ajitid Could you please post a screenshot for this?

@ajitid
Copy link
Contributor Author

ajitid commented Jun 24, 2017

Line below User Settings

Maybe this line below User Settings isn't cutomisable...

capture

27510349-0d265400-592c-11e7-97cf-a39f46a4d25c


Determine whether the separator line of the command bar is customizable.

But this one is though:

screenshot 154 _li

screenshot 153 _li

@arcticicestudio
Copy link
Contributor

It seems like there is no way to change the line of the user settings.
I've changed the color of the separator line of the command bar (Quick Open) which is controlled by the pickerGroup.border selector.

@arcticicestudio
Copy link
Contributor

🚢 Shipped with extension release version 🏷 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants