Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color tokens for secondary buttons of custom dialogs #207

Closed
arcticicestudio opened this issue Jun 20, 2021 · 0 comments · Fixed by #216
Closed

Color tokens for secondary buttons of custom dialogs #207

arcticicestudio opened this issue Jun 20, 2021 · 0 comments · Fixed by #216

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jun 20, 2021

VS Code 1.56 (April 2021) introduced new colors tokens for secondary buttons of custom dialogs:

  • button.secondaryBackground
  • button.secondaryForeground
  • button.secondaryHoverBackground

This will also include a visual improvement for the current Nord theme styles of primary buttons:

  • button.background - nord2 to nord8 with a transparency of ~93%.
  • button.foreground - nord4 to nord0.
  • button.hoverBackground - nord3 to nord8.
@arcticicestudio arcticicestudio added this to the Next milestone Jun 20, 2021
arcticicestudio added a commit that referenced this issue Jun 22, 2021
VS Code 1.56 [1] (April 2021) introduced new colors tokens for secondary
buttons of custom dialogs [2]:

- `button.secondaryBackground`
- `button.secondaryForeground`
- `button.secondaryHoverBackground`

This commit also includes visual improvements for the current Nord theme
styles of primary buttons:

- `button.background` - `nord2` to `nord8` with a transparency of ~93%.
- `button.foreground` - `nord4` to `nord0`.
- `button.hoverBackground` - `nord3` to `nord8`.

[1]: https://code.visualstudio.com/updates/v1_56
[2]: https://code.visualstudio.com/updates/v1_56#_updated-custom-dialogs

Co-authored-by: Sven Greb <development@svengreb.de>

GH-207
arcticicestudio added a commit that referenced this issue Jun 22, 2021
VS Code 1.56 [1] (April 2021) introduced new colors tokens for secondary
buttons of custom dialogs [2]:

- `button.secondaryBackground`
- `button.secondaryForeground`
- `button.secondaryHoverBackground`

This commit also includes visual improvements for the current Nord theme
styles of primary buttons:

- `button.background` - `nord2` to `nord8` with a transparency of ~93%.
- `button.foreground` - `nord4` to `nord0`.
- `button.hoverBackground` - `nord3` to `nord8`.

[1]: https://code.visualstudio.com/updates/v1_56
[2]: https://code.visualstudio.com/updates/v1_56#_updated-custom-dialogs

Co-authored-by: Sven Greb <development@svengreb.de>

GH-207
arcticicestudio added a commit that referenced this issue Jun 22, 2021
VS Code 1.56 [1] (April 2021) introduced new colors tokens for secondary
buttons of custom dialogs [2]:

- `button.secondaryBackground`
- `button.secondaryForeground`
- `button.secondaryHoverBackground`

This commit also includes visual improvements for the current Nord theme
styles of primary buttons:

- `button.background` - `nord2` to `nord8` with a transparency of ~93%.
- `button.foreground` - `nord4` to `nord0`.
- `button.hoverBackground` - `nord3` to `nord8`.

[1]: https://code.visualstudio.com/updates/v1_56
[2]: https://code.visualstudio.com/updates/v1_56#_updated-custom-dialogs

Co-authored-by: Sven Greb <development@svengreb.de>

Closes GH-207
arcticicestudio added a commit that referenced this issue Jun 22, 2021
VS Code 1.56 [1] (April 2021) introduced new colors tokens for secondary
buttons of custom dialogs [2]:

- `button.secondaryBackground`
- `button.secondaryForeground`
- `button.secondaryHoverBackground`

This commit also includes visual improvements for the current Nord theme
styles of primary buttons:

- `button.background` - `nord2` to `nord8` with a transparency of ~93%.
- `button.foreground` - `nord4` to `nord0`.
- `button.hoverBackground` - `nord3` to `nord8`.

[1]: https://code.visualstudio.com/updates/v1_56
[2]: https://code.visualstudio.com/updates/v1_56#_updated-custom-dialogs

Co-authored-by: Sven Greb <development@svengreb.de>

Closes GH-207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants