Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set textCodeBlock.background #155

Closed
octref opened this issue Sep 16, 2019 · 1 comment · Fixed by #158
Closed

Set textCodeBlock.background #155

octref opened this issue Sep 16, 2019 · 1 comment · Fixed by #158
Labels
context-ui scope-compatibility scope-ux type-feature
Milestone
version-0.13.0

Comments

@octref
Copy link
Contributor

octref commented Sep 16, 2019

By not setting textCodeBlock.background hover/completion could look like this for inline code blocks:

image

image

I suggest adding a light background.

You can test this example by opening https://github.com/microsoft/vscode-custom-data/tree/master/samples/helloworld, opening test.html and hover on my-button.
arcticicestudio added a commit that referenced this issue Oct 3, 2019
@arcticicestudio
Add textCodeBlock.background with value nord3
4294dc6 
Features like "Quick Doc" using this theme key to style the background
color of code blocks in the documentation text. by default this uses a
very dark color. This commit changes the color to use `nord3` instead.

GH-155
@arcticicestudio arcticicestudio mentioned this issue Oct 3, 2019
Merged
@arcticicestudio arcticicestudio added this to the Next milestone Oct 3, 2019
@arcticicestudio
Copy link
Contributor

Hi @octref 👋, thanks for your contribution 👍

I've submitted #158 that adds the theme key using nord3 as brighter background color compared to the default color.

arcticicestudio added a commit that referenced this issue Oct 3, 2019
@arcticicestudio
textCodeBlock.background workbench theme key (#158)
7be0eaf 
Added the `textCodeBlock.background` workbench theme key that is used by
VS Code features like the IntelliSense "quick info" (1) to style the
background color of code blocks in the documentation text. By default
this uses a very dark color.
This PR changes the color to use `nord3` instead.

References:
  (1) https://code.visualstudio.com/docs/editor/intellisense

Resolves GH-155
arcticicestudio added a commit that referenced this issue Dec 23, 2019
@arcticicestudio
textCodeBlock.background workbench theme key (#158)
b8b722e 
Added the `textCodeBlock.background` workbench theme key that is used by
VS Code features like the IntelliSense "quick info" (1) to style the
background color of code blocks in the documentation text. By default
this uses a very dark color.
This PR changes the color to use `nord3` instead.

References:
  (1) https://code.visualstudio.com/docs/editor/intellisense

Resolves GH-155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-ui scope-compatibility scope-ux type-feature
Projects
None yet
Milestone
version-0.13.0
Development

Successfully merging a pull request may close this issue.

textCodeBlock.background workbench theme key nordtheme/visual-studio-code
2 participants
@octref @arcticicestudio