Update syntax color to make them richer

[octref]

First, thanks a lot for the workbench update. I'm using it and it's awesome.

However, I hope the syntax can be updated a bit to match the richness of Dark+'s syntax highlighting. When I'm working on TS, I rely on colors as visual cues. For example, Type information is always marked as Green.

Here is a pic of Dark+ vs Nord.

[Livven]

Completely agree. Ideally maybe the syntax colors could be simply based on the default (dark+/light+) themes, so that each color value from the default theme is replaced with the same color value every time. This way you'd get exactly the same behavior and "richness" as the default theme, only with a different aesthetic.

Obviously for the workbench you might want to get a bit more creative (as in having the same background color for all three panels which may not be possible with the above method) but for syntax colors I don't think this kind of customization is necessary.

[pomadin]

@arcticicestudio Hi, indeed the theme is pretty cool. It seems that there are some mismatchings (misprints?) in scope names. For instance

      "name": "Entity Name Class/Type",
      "scope": [
        "entity.name.class",
        "entity.name.type.class" // should it be: entity.name.type?
        ],

[arcticicestudio]

@octref I've used their builtin migration tool which converted the TextMate theme automatically into the JSON format, but it may be that there have been some converting problems.
I'll try to check all scopes next weekend.

@pomadin I've already thought about checking all scopes since the described issues worked before I've migrated to the new theming API.

[Livven]

@arcticicestudio Pretty sure TS types not being highlighted was an issue in the previous version (before the workbench update) already, before the switch to the JSON format.

[octref]

Don't know if you are aware, but Cmd+Shift+P -> Inspect TM Scopes helps a lot for diagnosing.

Also, take a look at this folder: https://github.com/Microsoft/vscode/tree/master/extensions/theme-defaults/themes

dark_plus includes dark_vs, which includes dark_default.
I believe Nord already covers dark_vs, so you just need to have those in dark_plus added to the theme, like such:

[octref]

I can do a PR if you are ok with it. I really want to use Nord as my daily driver but this lack of functionality makes it unusable for me :-(

[arcticicestudio]

Sorry for the late reply, I'm really busy the whole week long. I hope to get some time this weekend. Anyway, feel free to open a PR, I'm always thankful for any help 😄 That would also take me a lot of work to write a script compare the differences of the JSON keys to find missing scopes 😆

[Ikuyadeu]

I think these need variable
For example vscode dark+

Variable

		{
			"name": "Variable and parameter name",
			"scope": [
				"variable",
				"meta.definition.variable.name",
				"support.variable"
			],
			"settings": {
				"foreground": "#9CDCFE"
			}
		},

[arcticicestudio]

Sorry for the late response, haven't got time for private projects the last months.
I've pushed some changes regarding missing TypeScript syntax highlights and some CSS improvements.

[octref]

Thanks a lot! Looking forward to 0.4.0 release.

[arcticicestudio]

🚢 Shipped with extension release version 🏷 0.4.0.