Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Pick doesn't show borders that separate group #100

Closed
octref opened this issue Sep 20, 2018 · 3 comments · Fixed by #103
Closed

Quick Pick doesn't show borders that separate group #100

octref opened this issue Sep 20, 2018 · 3 comments · Fixed by #103
Labels
context-ui scope-quality type-improvement
Milestone
version-0.7.0

Comments

@octref
Copy link
Contributor

octref commented Sep 20, 2018

Nord:

image

Dark+:

image
@arcticicestudio arcticicestudio added the hacktoberfest This repository participates in the Hacktoberfest label Oct 1, 2018
@ajitid ajitid mentioned this issue Oct 1, 2018
Merged
@arcticicestudio arcticicestudio added this to the 0.7.0 milestone Oct 1, 2018
@arcticicestudio arcticicestudio added good first issue GitHub filter label for newcomers and first time Open Source contributors status-review labels Oct 1, 2018
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Oct 1, 2018 •
edited
Loading

Thanks for your contribution 👍

I've removed it in the first place because it made the whole drop-down look divided and broken into multiple pieces and a bit cluttered instead of smooth transitions into the next section. It was still distinguishable through the names of the labels on the right, so maybe changing the color of these to e.g. nord8 might be better?

gh-100-colored-label

@octref Let me know what you think so @ajitid can adjust #103 to match this change.
Ah, and grats for joining the VS Code team, saw some of your implementations in latest versions (screenshots/screencasts with Nord theme 😄 ). Also using your nice polacode extension for ✨ code screenshots.

@octref
Copy link
Contributor Author

octref commented Oct 1, 2018

Changing the group name is a welcoming change, but I'm not sure if that solves the original problem — it's hard to see which item on the left is on the same level as Explorer, so I cannot immediately determine what group Outline is in.

Ah, and grats for joining the VS Code team, saw some of your implementations in latest versions (screenshots/screencasts with Nord theme 😄 ). Also using your nice polacode extension for ✨ code screenshots.

😉

@arcticicestudio
Copy link
Contributor

Yeah, might be a bit uncomfortable to see this when you don't have a ruler at hand next to your monitor.
So I'll merge #103 and create a separate PR for the labels too. Thanks for your feedback.

arcticicestudio added a commit that referenced this issue Oct 2, 2018
@arcticicestudio
Merge pull request #103 from ajitid/patch-2
5ba2ac5 
Enable group borders in Quick Picker dropdown again

The separators have been disabled in the first place because it made the whole drop-down look divided and broken into multiple pieces and a bit cluttered instead of smooth transitions into the next section. It was still distinguishable through the names of the labels on the right. However, it was hard to see which item on the left is on the same level as the label to immediately determine what the next item's group.
This has been change by enabling the borders again for better visual distinction.

Closes GH-100
@arcticicestudio arcticicestudio mentioned this issue Mar 21, 2019
Closed
arcticicestudio added a commit that referenced this issue Mar 21, 2019
@arcticicestudio
Improve label font color of view quick panel
d63fa3f 
Improved, like mentioned in GH-100 (1), the label of the `view` quick
panel to stand out more when by using `nord8` instead of `nord4` as
foreground color.

References:
  (1) #100 (comment)

GH-109
@svengreb svengreb added scope-quality and removed hacktoberfest This repository participates in the Hacktoberfest good first issue GitHub filter label for newcomers and first time Open Source contributors scope-ux labels Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-ui scope-quality type-improvement
Projects
None yet
Milestone
version-0.7.0
Development

Successfully merging a pull request may close this issue.

show quick picker group border
3 participants
@octref @arcticicestudio @svengreb