Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition to new JSON based syntax color scheme format #22

Closed
arcticicestudio opened this issue Aug 3, 2019 · 0 comments · Fixed by #24
Closed

Transition to new JSON based syntax color scheme format #22

arcticicestudio opened this issue Aug 3, 2019 · 0 comments · Fixed by #24
Labels
context-syntax scope-compatibility scope-maintainability scope-stability type-feature
Milestone
0.1.0

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Aug 3, 2019 •
edited
Loading

As of Sublime Text 3 build 3149, a new JSON based color scheme format .sublime-color-scheme was introduced for easier editing, customization and addition of new features. The documentation for the new format is available at the main Color Schemes documentation.
Nord will migrate to the new format (JSON) from the now deprecated/legacy .tmTheme format (XML).

All versions greater or equal to 3.1 build 3120 come with a builtin tool to convert legacy themes to the new format through the command palette only when the files is opened in the editor: „Convert Color Scheme“

@kaine119 already submitted #20 that'll be used as base and will be extended to align with Nord's style guidelines, adding missing keys and using the color palette feature that allows to define variables instead of using "hard-coded" HEX values.
@arcticicestudio arcticicestudio added this to the 0.1.0 milestone Aug 3, 2019
@arcticicestudio arcticicestudio self-assigned this Aug 3, 2019
arcticicestudio pushed a commit that referenced this issue Aug 6, 2019
@kaine119 @arcticicestudio
Transition to new JSON based syntax color scheme format
b30d6f6 
As of Sublime Text 3 build 3149, a new JSON based color scheme format
`.sublime-color-scheme` was introduced for easier editing, customization
and addition of new features. The documentation for the new format is
available at the main "Color Schemes" documentation (1).
Nord will migrate to the new format (JSON) from the now deprecated/legacy `.tmTheme` format (XML).

All versions greater or equal to 3.1 build 3120 come with a builtin tool
to convert legacy themes to the new format through the command palette
only when the files is opened in the editor**: „Convert Color Scheme“

The foloowing additional changes and additions for features that have
been introduced withg the new JSON color scheme format are included:

- Added all Nord colors as variables to the `variables` object that are
  exposed through Sublime Text's internal CSS color scheme API to reuse
  them with the CSS `var()` function for the defined scope rules.
- Added additional syntax-specific variables to the `variables` object
  to ensure a uniform color usage for scopes with the same context as
  well as reducing code duplication and possible transmission errors.
- Added the new Git gutter diff keys `line_diff_added`,
  `line_diff_modified` and `line_diff_deleted` to the `globals` object
  to ensure they match Nord's style. (@kaine119)

The now officially deprecated `.tmTheme` color scheme format file (2)
has been removed and is not supported by the Nord theme package anymore.

References:
  (1) https://www.sublimetext.com/docs/3/color_schemes.html
  (2) https://www.sublimetext.com/docs/3/color_schemes_tmtheme.html

Co-authored-by: Kai En <muikaien1@gmail.com>
Merged with GH-20
GH-22
@arcticicestudio arcticicestudio mentioned this issue Aug 6, 2019
Merged
arcticicestudio added a commit that referenced this issue Aug 6, 2019
@arcticicestudio
Transition to new JSON based syntax color scheme format (#24)
294ab7c 
As of Sublime Text 3 build 3149, a new JSON based color scheme format
`.sublime-color-scheme` (1) was introduced for easier editing,
customization and addition of new features. The documentation for the
new format is available at the main "Color Schemes" documentation (1).
Nord has been migrated to the new format (JSON) from the now
deprecated/legacy `.tmTheme` format (XML) (2).

All versions greater or equal to 3.1 build 3120 come with a builtin tool
to convert legacy themes to the new format through the command palette
only when the files is opened in the editor**: „Convert Color Scheme“

The following additional changes and additions for features that have
been introduced with the new JSON color scheme format are included:

- Added all Nord colors as variables to the `variables` object that are
  exposed through Sublime Text's internal CSS color scheme API to reuse
  them with the CSS `var()` function for the defined scope rules.
- Added additional syntax-specific variables to the `variables` object
  to ensure a uniform color usage for scopes with the same context as
  well as reducing code duplication and possible transmission errors.
- Added the new Git gutter diff keys `line_diff_added`,
  `line_diff_modified` and `line_diff_deleted` to the `globals` object
  to ensure they match Nord's style. (@kaine119)

The now officially deprecated `.tmTheme` color scheme format file (2)
has been removed and is not supported by the Nord theme package anymore.

References:
  (1) https://www.sublimetext.com/docs/3/color_schemes.html
  (2) https://www.sublimetext.com/docs/3/color_schemes_tmtheme.html

Co-authored-by: Kai En <muikaien1@gmail.com>
Includes GH-20
Resolves GH-22
@arcticicestudio arcticicestudio removed their assignment Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-syntax scope-compatibility scope-maintainability scope-stability type-feature
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Transition to new JSON based syntax color scheme format nordtheme/sublime-text
1 participant
@arcticicestudio