Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SonarQube minor rule squid:S3400 #8

Closed
arcticicestudio opened this issue Dec 3, 2016 · 0 comments
Closed

SonarQube minor rule squid:S3400 #8

arcticicestudio opened this issue Dec 3, 2016 · 0 comments
Labels
type-improvement
Milestone
0.2.0

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Dec 3, 2016 •
edited
Loading

The public API method getVersion() : String should be static and return a String constant VERSION to adapt to the SonarQube rule squid:S3400.

The unit test should be refactored to test against the ArcVer library arcver-java.
@arcticicestudio arcticicestudio self-assigned this Dec 3, 2016
arcticicestudio added a commit that referenced this issue Dec 3, 2016
@arcticicestudio
GHI-#8 Add VERSION constant and make method getVersion() static
e26e5cf
arcticicestudio added a commit that referenced this issue Dec 3, 2016
@arcticicestudio
GHI-#8 Refactor getVersion() unit test to run against arcver-java
b4d2e36
arcticicestudio referenced this issue Dec 3, 2016
@arcticicestudio
Merge branch 'improvement/ghi-#8-sonarqube-minor-rule-squid-s3400' in…
7efc44c 
…to develop
arcticicestudio added a commit that referenced this issue Dec 3, 2016
@arcticicestudio
GHI-#8 Update IntelliJ project file
0c032ca
@arcticicestudio arcticicestudio removed their assignment Sep 23, 2017
@arcticicestudio arcticicestudio added this to the 0.2.0 milestone Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-improvement
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@arcticicestudio