Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme instructions are incorrect #15

Closed
jantari opened this issue Apr 20, 2020 · 2 comments · Fixed by #19
Closed

readme instructions are incorrect #15

jantari opened this issue Apr 20, 2020 · 2 comments · Fixed by #19
Labels
context-documentation priority-medium scope-stability scope-ux type-bug
Milestone
version-next

Comments

@jantari
Copy link

jantari commented Apr 20, 2020

In the README.MD,

the following command is suggested:

test -r "~/.dir_colors" && eval $(dircolors ~/.dir_colors)

but it won't work ( tested on Debian 10, bash 5.0-4 ).
image

The quotes need to be ommited and the command should be:

test -r ~/.dir_colors && eval $(dircolors ~/.dir_colors)

The problem is explained here: https://serverfault.com/a/417255
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Apr 27, 2020 •
edited
Loading

Hi @jantari 👋, thanks for your contribution 👍

Well recognized, variable/parameter expansion are always are always a great pitfall (even though the screenshot of the command in the README is correct) 😄
Would you like to submit a PR o fix this in this repository as well as for the port project documentations?

@arcticicestudio arcticicestudio added this to the Next milestone Apr 27, 2020
@arcticicestudio arcticicestudio added the Hacktoberfest This repository participates in the Hacktoberfest label Oct 8, 2020
@ghost
Copy link

ghost commented Nov 10, 2020

#19 is open to address this.

@ghost ghost mentioned this issue Nov 10, 2020
Merged
@arcticicestudio arcticicestudio removed the Hacktoberfest This repository participates in the Hacktoberfest label Nov 13, 2020
arcticicestudio pushed a commit that referenced this issue Nov 29, 2020
Remove quotes from installation instructions (#19)
35166d3 
Removed the quotes from around `~/.dir_colors` in the installation
instructions. Before the shell specific tilde character was not resolved
via variable expansion but used as literal character instead. 

Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
Co-authored-by: Sven Greb <development@svengreb.de>

Fixes GH-15
Fixes GH-18
Related to GH-11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-documentation priority-medium scope-stability scope-ux type-bug
Projects
None yet
Milestone
version-next
Development

Successfully merging a pull request may close this issue.

Remove quotes from installation instructions
2 participants
@arcticicestudio @jantari