Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Colors From syntax--source And syntax--meta #56

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Remove Colors From syntax--source And syntax--meta #56

merged 1 commit into from
Jan 15, 2018

Conversation

amayer5125
Copy link
Contributor

Fixes #54
Fixes #52

@amayer5125
Copy link
Contributor Author

If this is accepted we should revert #53

@arcticicestudio arcticicestudio self-requested a review October 23, 2017 18:45
@arcticicestudio arcticicestudio self-assigned this Oct 23, 2017
@arcticicestudio arcticicestudio added type-bug Hacktoberfest This repository participates in the Hacktoberfest labels Oct 23, 2017
@arcticicestudio arcticicestudio added this to the 0.9.2 milestone Oct 23, 2017
@amayer5125
Copy link
Contributor Author

Anything else I would need to do for this?

@arcticicestudio
Copy link
Contributor

Sorry for the long delay ⌚

I've locally checked out this PR and will test the changes over the weekend to see if there are any cases where the highlighting might break due to the removed rules. I do not expect something to break, but I'd like to make sure the highlighting stays consistent.

arcticicestudio
arcticicestudio approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the change during my weekend coding sessions and I haven't notice any side effects or disadvantages so let's merge it. Thanks again for the fix 👍

@arcticicestudio arcticicestudio merged commit ee33f61 into nordtheme:develop Jan 15, 2018
@arcticicestudio arcticicestudio removed their assignment Jan 15, 2018
@arcticicestudio arcticicestudio modified the milestones: 0.9.2, 0.10.0 Jan 15, 2018
@arcticicestudio arcticicestudio mentioned this pull request Jan 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcticicestudio arcticicestudio arcticicestudio approved these changes

Assignees
No one assigned
Labels
Hacktoberfest This repository participates in the Hacktoberfest type-bug
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amayer5125 @arcticicestudio