Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary IO write event on package deactivation #49

Closed
arcticicestudio opened this issue Apr 14, 2017 · 1 comment
Closed

Unnecessary IO write event on package deactivation #49

arcticicestudio opened this issue Apr 14, 2017 · 1 comment
Labels
context-config type-improvement
Milestone
0.9.1

Comments

@arcticicestudio
Copy link
Contributor

When deactivating the package all theme setting will be unnecessarily written out to the store file theme-settings-store.less. There is currently no need to handle a package deactivation event.
@arcticicestudio arcticicestudio self-assigned this Apr 14, 2017
arcticicestudio added a commit that referenced this issue Apr 14, 2017
@arcticicestudio
GHI-#49 Remove unnecessary IO events on package deactivation
461b090 
Removed the "deactivation()" method since there is currently no need to handle a package deactivation event.
arcticicestudio referenced this issue Apr 14, 2017
@arcticicestudio
Merge branch 'improvement/ghi-#49-unnecessary-io-write-event-on-packa…
892e673 
…ge-deactivation' into develop
@arcticicestudio
Copy link
Contributor Author

🚢 Shipped with APM package release version 🏷 0.9.1.

@arcticicestudio arcticicestudio added this to the 0.9.1 milestone Jul 8, 2017
@arcticicestudio arcticicestudio removed their assignment Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-config type-improvement
Projects
None yet
Milestone
0.9.1
Development

No branches or pull requests
1 participant
@arcticicestudio