Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Multiple wildcard in url is broken #26

Closed
tdelmas opened this issue Dec 17, 2015 · 1 comment
Closed

Multiple wildcard in url is broken #26

tdelmas opened this issue Dec 17, 2015 · 1 comment
Labels
Milestone

Comments

@tdelmas
Copy link

tdelmas commented Dec 17, 2015

According to the documentation https://github.com/nordnet/cordova-universal-links-plugin#path path with multiple wildcard are valid
Example :
<path url="*mypath*" />

But the generated AndroidManifest contains :
<data android:pathPattern="/.*mypath*"/>
(note the missing point before the last wildcard)

I think that line is responsible :
https://github.com/nordnet/cordova-universal-links-plugin/blob/master/hooks/lib/android/manifestWriter.js#L301

pathName = pathName.replace('*', '.*');

It should be :

pathName = pathName.replace(/\*/g, '.*');

@nikDemyankov nikDemyankov added this to the v1.1.0 milestone Dec 17, 2015
@nikDemyankov
Copy link
Member

Thanks, will check it out.

nikDemyankov added a commit that referenced this issue Dec 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants