This repository has been archived by the owner on Oct 1, 2018. It is now read-only.
Set default connection timeout to match with iOS counterpart #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, agree, it should have some timeout on connection. I will also add read timeout. Thanks! |
nikDemyankov
added a commit
that referenced
this pull request
Mar 7, 2016
|
Merged into dev/v1.3.0 branch. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android version using
URLConnectionclass to fetch config file and download files. If I'm not mistaken, the class has default connection timeout is0which is infinite, seems a bit too long for me :)I'm not Java expert, just blindly adding in so please take a look and let me know if I'm missing something
Cheers