Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Add support for new version of cordova ios platform - 4.0 #64

Closed
nikDemyankov opened this issue Dec 10, 2015 · 10 comments
Closed

Add support for new version of cordova ios platform - 4.0 #64

nikDemyankov opened this issue Dec 10, 2015 · 10 comments

Comments

@nikDemyankov
Copy link
Member

Right now the latest version, that is installed when you run cordova platform add ios is 3.9.2. And plugin works with it.

But soon it will be 4.0.0. In the new version they have changed the API, so plugin will not build. Need to support old and new version of cordova ios platform.

@nikDemyankov nikDemyankov added this to the v1.1.3 milestone Dec 10, 2015
@nikDemyankov
Copy link
Member Author

Fix is easy, but there is a problem with caching as in #47. If before it was more or less decent , after the fix - the only good solution right now is to add query parameter to js, css and img files in html. Have some ideas how to fix that, but it will take time for experiments, so please, be patient.

@nikDemyankov nikDemyankov removed this from the v1.1.3 milestone Dec 11, 2015
@Manduro
Copy link
Contributor

Manduro commented Dec 17, 2015

Could we have the fix for 4.0.0 with the requirement of a query string? I already have those implemented and would like to use the new release. Thanks!

@nikDemyankov
Copy link
Member Author

I can upload a fix on the github, but don't want to release it on npm. You will have to install it from the github like so:

cordova plugin add https://github.com/nordnet/cordova-hot-code-push.git

If that's fine - I will do it soon.

@Manduro
Copy link
Contributor

Manduro commented Dec 17, 2015

Sure, that's fine!

@nikDemyankov
Copy link
Member Author

Done. And I think a hacked for now css caching problem. But that hack will go away eventually.

@nikDemyankov nikDemyankov added this to the v1.2 milestone Dec 18, 2015
@Manduro
Copy link
Contributor

Manduro commented Jan 7, 2016

@nikDemyankov I wasn't able to bust the cache on the previous chcp version on cordova-ios@4, even with a query parameter.

I see 1.2.0 has fixed this, but while trying it out I run into this error on running the app through XCode on my own device:

2016-01-07 15:57:22.730 App[3662:1346573] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[NSURL URLByAppendingPathComponent:isDirectory:]: component, components, or pathExtension cannot be nil.'
*** First throw call stack:
(0x1819f5900 0x181063f80 0x1819f5848 0x18230ebb0 0x100122da8 0x100122c2c 0x10011a418 0x10011975c 0x100131a40 0x100131e84 0x10012fe90 0x1000fdfec 0x1866e80c0 0x1866e7cc4 0x1866eeab4 0x1866ebfa0 0x186761cd0 0x1001336b4 0x1000fdce8 0x18675d704 0x18698c130 0x1869904b8 0x18698d5c0 0x182fab790 0x182fabb10 0x1819acefc 0x1819ac990 0x1819aa690 0x1818d9680 0x186756580 0x186750d90 0x1000fdbd0 0x18147a8b8)
libc++abi.dylib: terminating with uncaught exception of type NSException

Do you know what causes this?

PS: This is without the dev plugin.

@nikDemyankov
Copy link
Member Author

Are you running it over the previous version of the app?

What will happen, if you remove it from device and try to run again?

@Manduro
Copy link
Contributor

Manduro commented Jan 7, 2016

That fixes it, thanks! All seems to work fine here on cordova-ios@4, so I guess you can close this as well ;)

@nikDemyankov
Copy link
Member Author

Good, but I think I reproduced it. It does happen, when you install new app over the old one. Will look into that, but yes - that is a separate issue. This one is closed.

@nikDemyankov
Copy link
Member Author

Released v1.2.1 with the fix for app crash, when running it on the previous version. Thanks @Manduro for noticing it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants