Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Fail on android build --release #49

Closed
majormittens opened this issue Nov 28, 2015 · 3 comments
Closed

Fail on android build --release #49

majormittens opened this issue Nov 28, 2015 · 3 comments
Labels
bug
Milestone
v1.1.2

Comments

@majormittens
Copy link

add to body class: platform-android
CHCP plugin after prepare hook:
Error: opt.indexOf is not a function

Any ideas? Really cool plugin overall. Managed to build with --release after removing the lines with opt.indexOf and opt.replace in afterPrepareHook.js
@nikDemyankov
Copy link
Member

Thanks. Know about this issue, same as #48. Will fix in next release.

@nikDemyankov nikDemyankov added this to the v1.1.2 milestone Nov 28, 2015
@nikDemyankov
Copy link
Member

This is because of the new version of Cordova. On the previous version (at least, 5.3.3) it returned options as array of strings: [--release]. Now (v5.4.1) console arguments are an object: { release: true, argv: [] }.

nikDemyankov added a commit that referenced this issue Nov 30, 2015
@nikDemyankov
Fixed support for Cordova 5.4. Fix for issues #49 and #48 .
ae85aa6
@nikDemyankov
Copy link
Member

Fixed in master branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.1.2
Development

No branches or pull requests
2 participants
@majormittens @nikDemyankov