Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for newer java versions and frameworks #37

Merged
merged 46 commits into from
Oct 8, 2024
Merged

Support for newer java versions and frameworks #37

merged 46 commits into from
Oct 8, 2024

Conversation

mloitm
Copy link
Contributor

@mloitm mloitm commented Oct 4, 2024

Dependencies updated, build migrated from Maven to Gradle.

Refs: XRDDEV-2628

mloitm added 30 commits July 25, 2024 11:23
@mloitm
build: initial maven to gradle migration
2a1b88b 
Refs: XRDDEV-2628
@mloitm
build: produce source and javadoc jars
801b365 
Refs: XRDDEV-2628
@mloitm
build: checkstyle
fd8c17b 
Refs: XRDDEV-2628
@mloitm
build: dependency-check
977e991 
Refs: XRDDEV-2628
@mloitm
build: license format
5a534b6 
Refs: XRDDEV-2628
@mloitm
build: include LICENSE and 3RD-PARTY-NOTICES in jar
16f7c0c 
Refs: XRDDEV-2628
@mloitm
build: maven publishing
82503bd 
Refs: XRDDEV-2628
@mloitm
build: dependencies cleanup
bc303ee 
Refs: XRDDEV-2628
@mloitm
build: removed maven build files
4da4769 
Refs: XRDDEV-2628
@mloitm
build: junit5 dependency
717cf63 
Refs: XRDDEV-2628
@mloitm
test: migrate tests to junit 5
e558118 
Refs: XRDDEV-2628
@mloitm
chore: update logging dependencies
eb0d222 
Refs: XRDDEV-2628
@mloitm
chore: migrate to Jakarta SOAP implementation
16a0e75 
Refs: XRDDEV-2628
@mloitm
fix: saaj api usage according to new version
4700704 
Refs: XRDDEV-2628
@mloitm
chore: migrate to jakarta servlet api
2383c49 
Refs: XRDDEV-2628
@mloitm
chore: migrate apache http client to version 5
2ba491e 
Refs: XRDDEV-2628
@mloitm
chore: org.json:json upgraded
3e0ef3c 
Refs: XRDDEV-2628
@mloitm
chore: example adapter initial migration from maven to gradle
fabfa6a 
Refs: XRDDEV-2628
@mloitm
chore: upgrade dependency check gradle plugin
58c5e80 
Refs: XRDDEV-2628
@mloitm
chore: example adapter dependencies updated
6a55f4a 
Refs: XRDDEV-2628
@mloitm
chore: fixed some compiler warnings
4f5b000 
Refs: XRDDEV-2628
@mloitm
chore: license headers updated
5ffd3c1 
Refs: XRDDEV-2628
@mloitm
chore: checkstyle
b5cd78e 
Refs: XRDDEV-2628
@mloitm
chore: example adapter build configuration
cf7c1ed 
Refs: XRDDEV-2628
@mloitm
chore: maven configuration file removed
aa8905f 
Refs: XRDDEV-2628
@mloitm
chore: gradle version updated to 8.10.1
599b277 
Refs: XRDDEV-2628
@mloitm
chore: license headers updated
49222e1 
Refs: XRDDEV-2628
@mloitm
test: tests for AbstractAdapterServlet
6b07218 
Refs: XRDDEV-2628
@mloitm
test: tests for AbstractAdapterServlet
e6cac88 
Refs: XRDDEV-2628
@mloitm
chore: checkstyle and licenses
16f3d90 
Refs: XRDDEV-2628
@mloitm mloitm requested review from a team and melbeltagy and removed request for a team October 4, 2024 13:19
melbeltagy
melbeltagy suggested changes Oct 4, 2024
View reviewed changes
Copy link

@melbeltagy melbeltagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a quick review, but I still have issues running ./gradlew build locally. Double checking if they are my machine issues or PR's issues :)

documentation/Setting-up-Development-Environment.md Outdated Show resolved Hide resolved
documentation/Setting-up-Development-Environment.md Show resolved Hide resolved
documentation/Setting-up-Development-Environment.md Show resolved Hide resolved
src/client/build.gradle.kts Outdated Show resolved Hide resolved
src/common/build.gradle.kts Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
src/config/dependency-check-suppressions.xml Outdated Show resolved Hide resolved
melbeltagy
melbeltagy suggested changes Oct 4, 2024
View reviewed changes
Copy link

@melbeltagy melbeltagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a second round of review (and the final one).
Sorry for the too much comments

src/build.gradle.kts Outdated Show resolved Hide resolved
example-adapter/src/main/java/org/niis/xrd4j/exampleadapter/ExampleAdapter.java Show resolved Hide resolved
src/client/build.gradle.kts Show resolved Hide resolved
src/common/src/main/java/org/niis/xrd4j/common/util/SOAPHelper.java Outdated Show resolved Hide resolved
src/server/src/integrationTest/java/org/niis/xrd4j/inttest/ServletTest.java Outdated Show resolved Hide resolved
src/server/src/integrationTest/java/org/niis/xrd4j/inttest/TestServlet.java Outdated Show resolved Hide resolved
src/common/src/main/java/org/niis/xrd4j/common/util/SOAPHelper.java Outdated Show resolved Hide resolved
...server/src/main/java/org/niis/xrd4j/server/serializer/AbstractServiceResponseSerializer.java Show resolved Hide resolved
melbeltagy
melbeltagy approved these changes Oct 8, 2024
View reviewed changes
Copy link

@melbeltagy melbeltagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @mloitm for your time.
This is a huge PR with lots of effort from your side put into it.

@mloitm mloitm merged commit bfd3bb1 into develop Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melbeltagy melbeltagy melbeltagy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mloitm @melbeltagy