Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added operations to example-adapter for soap attachments testing #32

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Added operations to example-adapter for soap attachments testing #32

merged 3 commits into from
Jun 6, 2024

Conversation

justasnortal
Copy link
Contributor

  • Added operations to example-adapter for soap attachments testing.
  • Fixed issue when empty response is returned from example adapter if request contains attachments.

@justasnortal justasnortal marked this pull request as ready for review June 5, 2024 13:24
@justasnortal justasnortal requested review from a team, ovidijusnortal and mloitm and removed request for a team and ovidijusnortal June 6, 2024 10:55
mloitm
mloitm reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@mloitm mloitm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you also add example requests/responses for new operations to example-adapter/examples and also update the example-adapter's readme.

@justasnortal justasnortal merged commit bb712ce into develop Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloitm mloitm mloitm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justasnortal @mloitm