Skip to content

chore: update diagnostic group title to add help text for clarity #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

raits
Copy link
Contributor

@raits raits commented Dec 10, 2024

  • Moved HelpButton to components/ui/HelpButton.vue from the original Keys and Certificates subview since it is a common component
  • Made the help image optional since it is not required for all cases of help text
  • Added help text to the mail notifications block to make it clearer which cases it will be used for

@raits raits requested a review from petkivim December 10, 2024 12:15
Copy link

Job Summary for Gradle

Build and test :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src
build sonar test intTest runProxyTest runMetaserviceTest ru…
8.10.2 Build Scan not published

@raits raits changed the title chore: update diagnostic group title to make the intention clearer chore: update diagnostic group title to add help text for clarity Dec 10, 2024
Copy link
Contributor

@petkivim petkivim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

Job Summary for Gradle

Build and test :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src
build sonar test intTest runProxyTest runMetaserviceTest ru…
8.10.2 Build Scan not published

Copy link

Job Summary for Gradle

Build and test :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src
build sonar test intTest runProxyTest runMetaserviceTest ru…
8.10.2 Build Scan not published

Copy link

Copy link

Job Summary for Gradle

Build and test :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src
build sonar test intTest runProxyTest runMetaserviceTest ru…
8.10.2 Build Scan not published

@raits raits merged commit d6483a6 into develop Dec 11, 2024
10 checks passed
@raits raits deleted the mail-status-text branch December 11, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants