Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: XRDDEV-2728 Complement - Adding Spanish language support #2448

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

figueroarvictor
Copy link
Contributor

@figueroarvictor figueroarvictor commented Nov 28, 2024

This Pull Request adds support for the Spanish language in the X-Road UI. The following changes were made:

  • Added es.json localization files for central-server, security-server, and shared-ui.
  • Updated the i18n.ts files to include Spanish as a supported language.
  • Updated the index.ts file in shared-ui to load Spanish localization.

Ref: XRDDEV-2787

@ovidijusnortal
Copy link
Contributor

@figueroarvictor
Hi, we extracted some additional common translations from Security server admin UI and Central server UI into shared-ui module to avoid translating same thing multiple times(#2464).
Can you check your PR and match up your translations with new versions of en locale files? at least one in shared-ui module

@figueroarvictor
Copy link
Contributor Author

@ovidijusnortal I am seeing that a language file for Estonia has also been added, so I will also update the scripts to incorporate it.

@figueroarvictor
Copy link
Contributor Author

@ovidijusnortal,
Hi, I've updated Spanish translations in all modules (shared-ui, central-server, and security-server) and added Estonian support in shared-ui.

@ovidijusnortal
Copy link
Contributor

@figueroarvictor
Hey,
looks good. Only left to wait for Estonian translations updated.

@raits
Copy link
Contributor

raits commented Dec 10, 2024

@figueroarvictor unfortunately, we needed to add a few new fields related to diagnostics: https://github.com/nordic-institute/X-Road/pull/2472/files#diff-c667a377a7d520d463b41c9734653e52d2ca512b236152a7dcf8d6bab0dfd7f8

Could you please update the Spanish translation to include these new fields as well?

@figueroarvictor
Copy link
Contributor Author

figueroarvictor commented Dec 10, 2024 via email

@raits
Copy link
Contributor

raits commented Dec 11, 2024

Hi Raido, Yes; I just need a few hours for push the updates needed. Regards

Thanks!

@figueroarvictor
Copy link
Contributor Author

Hi @raits,

Changes made in Security Server es.json file.

Regards,

@raits
Copy link
Contributor

raits commented Dec 12, 2024

Hi @raits,

Changes made in Security Server es.json file.

Regards,

Thank you!

@raits raits merged commit b6ad6e7 into nordic-institute:develop Dec 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants