Skip to content

Commit

Permalink
fix: ensure that manual key creation works in case ACME failures
Browse files Browse the repository at this point in the history
suggested fix

Refs: XRDDEV-2651
  • Loading branch information
ovidijusnortal committed Jun 28, 2024
1 parent 69e3907 commit 71822ef
Showing 1 changed file with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -230,12 +230,8 @@ List<String> buildPath(X509Certificate certificate,
}

public boolean isAcmeExternalAccountBindingRequired(String caName) throws CertificateAuthorityNotFoundException {
final var approvedCAInfo = getCertificateAuthorityInfo(caName);
if (approvedCAInfo.getAcmeServerDirectoryUrl() != null) {
return acmeService.isExternalAccountBindingRequired(approvedCAInfo.getAcmeServerDirectoryUrl());

}
return false;
final var acmeUrl = getCertificateAuthorityInfo(caName).getAcmeServerDirectoryUrl();
return acmeUrl != null && acmeService.isExternalAccountBindingRequired(acmeUrl);
}

public boolean hasAcmeExternalAccountBindingCredentials(String caName, String memberId) {
Expand Down

0 comments on commit 71822ef

Please sign in to comment.