Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes currently open dependabot security alerts #737

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Fixes currently open dependabot security alerts #737

merged 2 commits into from
Jan 2, 2025

Conversation

mgcm
Copy link
Contributor

@mgcm mgcm commented Dec 30, 2024

And all yarn audit reported issues (expect request-> see #725).

No changeset added as the issues only affect developer tooling.

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

mgcm added 2 commits December 30, 2024 17:23
@mgcm
Fixes currently open security dependabot alerts
a3b4603 
Signed-off-by: Milton Moura <miltonmoura@gmail.com>
@mgcm
Ignore playwright/no-wait-for-timeout linting error
be2a0a3 
Signed-off-by: Milton Moura <miltonmoura@gmail.com>
@mgcm mgcm marked this pull request as ready for review December 31, 2024 09:56
@mgcm mgcm requested a review from a team December 31, 2024 09:56
@jaller94 jaller94 changed the title Fixes currrently open dependabot security alerts Fixes currently open dependabot security alerts Dec 31, 2024
jaller94
jaller94 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as long as the test with waitForTimeout isn't flanking.

@mgcm mgcm merged commit 7839d9c into main Jan 2, 2025
6 checks passed
@mgcm mgcm deleted the nic/fix/security-alerts branch January 2, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

@ahmadkadri ahmadkadri ahmadkadri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgcm @jaller94 @ahmadkadri