-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It is not possible to reschedule a meeting when the series is already started #321
It is not possible to reschedule a meeting when the series is already started #321
Conversation
…arted series). add and fix tests Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
|
…edule-a-meeting-when-the-series-is-already-started
@@ -873,15 +873,16 @@ describe('<ScheduleMeeting>', () => { | |||
it('should disabled submission if meeting series is changed to start in the past', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry to nitpick but "should disable" and "should not disable" is the more correct - in this line and the others below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me - only the test closure description should be changed to address my comment about the "disable" vs "disabled" typo
Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
…edule-a-meeting-when-the-series-is-already-started
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…arted series).
add and fix tests
✔️ Checklist
Signed-off-by
line in the message (more info).