Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to reschedule a meeting when the series is already started #321

Conversation

ahmadkadri
Copy link
Contributor

@ahmadkadri ahmadkadri commented Oct 13, 2023

…arted series).

add and fix tests

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

…arted series).

add and fix tests

Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

⚠️ No Changeset found

Latest commit: 6e8c59a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
@ahmadkadri ahmadkadri marked this pull request as ready for review October 16, 2023 10:20
@ahmadkadri ahmadkadri requested a review from a team as a code owner October 16, 2023 10:20
…edule-a-meeting-when-the-series-is-already-started
@@ -873,15 +873,16 @@ describe('<ScheduleMeeting>', () => {
it('should disabled submission if meeting series is changed to start in the past', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry to nitpick but "should disable" and "should not disable" is the more correct - in this line and the others below

Copy link
Contributor

@mgcm mgcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - only the test closure description should be changed to address my comment about the "disable" vs "disabled" typo

Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
…edule-a-meeting-when-the-series-is-already-started
@ahmadkadri ahmadkadri requested review from mgcm and a team October 18, 2023 15:00
Copy link
Contributor

@mgcm mgcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ahmadkadri ahmadkadri merged commit 0fa3340 into main Oct 19, 2023
6 checks passed
@ahmadkadri ahmadkadri deleted the nic/feat/PB-3608-It-is-not-possible-to-reschedule-a-meeting-when-the-series-is-already-started branch October 19, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants