replace unlink with rm #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felabr
force-pushed
the
replace-unlink-with-rm
branch
from
0cd60f1 to
3c6ae8b
Compare
|
sorry, that should have gone to my fork, and not to your repo |
|
Np. @felabr If I may ask, why did you need to swap it? |
|
Sure, there's some information in this discussion: #164 Our GitHub pipelines sometimes fail when running ts-patch, and the error message tells me |
|
Thanks for sharing! Seems reasonable to consider this. I'll need to check support on node versions and make sure there are no potential downsides. Will reopen for now |
felabr
force-pushed
the
replace-unlink-with-rm
branch
from
87e3a74 to
3c6ae8b
Compare
|
I cleaned it up a bit, the PR now only contains the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.