-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend: rebase llama.cpp submodule on latest upstream #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
This fixes CUDA symbol lookup errors caused by missing parts of the build script. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
cebtenzzre
force-pushed
the
update-llamacpp
branch
from
July 19, 2024 03:23
166377a
to
d0f5c89
Compare
New changes:
Gemma 2 still doesn't work perfectly due to familiar issues with special tokens in output causing an assertion failure in UI code (likely an unrecognized EOS token). |
manyoso
approved these changes
Jul 19, 2024
Have tested a bit and can't see anything that breaks |
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
cebtenzzre
added a commit
that referenced
this pull request
Jul 30, 2024
When llama.cpp was updated, I removed the space removal logic, but it turns out it's still actually needed. This is now a proper parameter, as we specifically only want to disable the *leading* space when we are tokenizing input that comes after a normal token. This fixes a regression in commit 290c629 ("backend: rebase llama.cpp submodule on latest upstream (#2694)"). Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the llama.cpp submodule to a version rebased on commit
ggerganov/llama.cpp@a15ef8fggerganov/llama.cpp@87e397d.To rebase successfully:
To get it to compile:
llama.cpp.cmake
had to be updated, as the repo was reorganized, and the OpenCL backend was removedThere were runtime complains about the NONE op not being supported, so I ran
test-backend-ops
. This crashed partway through, which led to significant changes to the way we are initializing/destroying resources with Kompute. The results of this are: