Markdown support #2476
Markdown support #2476
Conversation
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 320e184 in 1 minute and 6 seconds
More details
- Looked at
75lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_OgMDOApf7GpFkB33
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 7 days left in your free trial, upgrade for $20/seat/month or contact us.
| @@ -925,6 +926,17 @@ void ResponseText::handleTextChanged() | |||
| m_isProcessingText = false; | |||
| } | |||
|
|
|||
| void replaceAndInsertMarkdown(int startIndex, int endIndex, QTextDocument *doc) | |||
There was a problem hiding this comment.
The replaceAndInsertMarkdown function does not handle the case where endIndex is greater than the document's character count, which can lead to an out-of-range error. Consider adding a check to ensure endIndex does not exceed the document's character count before setting the cursor position.
| int nonCodeStart = lastIndex; | ||
| int nonCodeEnd = matchesCode[index].capturedStart(); | ||
| if (nonCodeEnd > nonCodeStart) | ||
| replaceAndInsertMarkdown(nonCodeStart, nonCodeEnd, doc); |
There was a problem hiding this comment.
The replaceAndInsertMarkdown function is called with nonCodeEnd as the second argument, which might not include the last character of the non-code segment due to how capturedStart() is defined. It might be necessary to adjust this by adding 1 to nonCodeEnd to include the last character of the segment.
| } | ||
|
|
||
| if (lastIndex < doc->characterCount()) | ||
| replaceAndInsertMarkdown(lastIndex, doc->characterCount() - 1, doc); |
There was a problem hiding this comment.
The replaceAndInsertMarkdown function is called with doc->characterCount() - 1 as the second argument, which might exclude the last character of the document. Consider using doc->characterCount() instead to include the entire document content.
Signed-off-by: Adam Treat <treat.adam@gmail.com>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 3799816 in 39 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. gpt4all-chat/qml/ChatView.qml:1004
- Draft comment:
The PR description mentions an adjustment to the width oflistView.contentItemby subtracting 15 units, but the diff provided does not show this change. Instead, it shows a change in the text of aTextAreaelement. Please ensure that the intended changes are correctly committed and reflected in the PR. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_sEMqASRzdEyeFGPq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 7 days left in your free trial, upgrade for $20/seat/month or contact us.
Signed-off-by: Adam Treat <treat.adam@gmail.com>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on cb8a4c4 in 1 minute and 0 seconds
More details
- Looked at
201lines of code in8files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. gpt4all-chat/qml/Theme.qml:197
- Draft comment:
TheconversationDividerproperty is directly returningdividerColorwithout considering the theme settings, which might not be consistent with the intended theme-specific customization. Consider using a switch case based onMySettings.chatThemeto return different colors for different themes, similar to other properties in this file. - Reason this comment was not posted:
Confidence of 30% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_wNZF5IgvGlVhm2Zd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 7 days left in your free trial, upgrade for $20/seat/month or contact us.
Summary:
Added markdown support in
ResponseText, adjusted UI element widths, and modified divider heights and colors in various QML files.Key points:
replaceAndInsertMarkdownfunction ingpt4all-chat/responsetext.cppto handle markdown insertion.ResponseText::handleCodeBlocksingpt4all-chat/responsetext.cppto process non-code blocks as markdown.listView.contentItemingpt4all-chat/qml/ChatView.qmlby subtracting 15 units.gpt4all-chat/qml/ApplicationSettings.qml,gpt4all-chat/qml/ChatDrawer.qml,gpt4all-chat/qml/ChatView.qml,gpt4all-chat/qml/CollectionsDrawer.qml,gpt4all-chat/qml/LocalDocsSettings.qml,gpt4all-chat/qml/ModelSettings.qml,gpt4all-chat/qml/MySettingsStack.qml) from 2 to 1 unit.conversationDividercolor ingpt4all-chat/qml/Theme.qmlto usedividerColor.Generated with ❤️ by ellipsis.dev