Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #2105 by using the original url for the download. #2107

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fixes issue #2105 by using the original url for the download. #2107

merged 1 commit into from
Mar 11, 2024

Conversation

manyoso
Copy link
Collaborator

@manyoso manyoso commented Mar 11, 2024

No description provided.

@manyoso
Fixes issue #2105 by using the original url for the download. This fi…
18f66d8 
…x is

valid because we expect the url to contain the actual filename at the end.
This also allows huggingface to track the download as happening.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso manyoso requested a review from apage43 March 11, 2024 16:28
@manyoso manyoso merged commit 0daf37a into main Mar 11, 2024
6 of 10 checks passed
@ThiloteE
Copy link
Collaborator

To ease organizational workflows it is possible to link the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

Example:

  • ✅ Fix #xyz links pull-request to issue. Merging the PR will close the Issue.
  • ✅ Fix https://github.com/nomic.ai/gpt4all/issues/xyz links pull-request to issue. Merging the PR will close the Issue.
  • ✅ Fix https://github.com/ThiloteE/gpt4all/issues/xyz links pull-request to issue. Merging the PR will close the Issue.
  • ❌ Fix [#xyz](https://github.com/Nomic.AI/GPT4All/issues/xyz) links pull-request to issue. Merging the PR will NOT close the Issue.

@ThiloteE ThiloteE mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apage43 apage43 apage43 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manyoso @ThiloteE @apage43