Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2024 Use the currently selected chat model as the default displayed when opening settings to update parameters #2099

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

chrisbarrera
Copy link
Contributor

…x to the currently selected chat model

Describe your changes

As described in issue #2024 the model/character settings does not default to the currently selected chat model when opened. This commit addresses that.

Issue ticket number and link

#2024

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Steps to Reproduce

Described in #2024

… combobox to the currently selected chat model

Signed-off-by: chrisbarrera <34655880+chrisbarrera@users.noreply.github.com>
@chrisbarrera chrisbarrera changed the title #2024 Update ModelSettings.qml to default model/char settings combobo… #2024 Use the currently selected chat model as the default displayed when opening settings to update parameters Mar 9, 2024
@chrisbarrera
Copy link
Contributor Author

Just a comment on the actual behavior of this change:

  1. When a model is selected in chat, it will be the first model seen in settings (model/character combobox) when opened. (desirable behavior)
  2. If other model(s) are selected in the settings model/character combobox, and settings is closed and reopened, the most recently selected model in the settings model/character combobox will be visible. (reasonable behavior, though not entirely consistent with the purpose of this change)
  3. If a new model is selected in chat following (2) above, behavior per (1) above will be seen (i.e. the selected chat model will be the first seen in settings). (desirable behavior)

@manyoso manyoso merged commit 61d6765 into nomic-ai:main Mar 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants