chat: better handle case where network reachability is unknown #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, QNetworkInformation uses NetworkManager by default. I don't have NetworkManager (I use systemd-networkd), so I get no download button, and I get this warning on console:
Change this so that the download button appears and there is no warning.
Question: Is QNetworkInformation even the right thing here? It's clearly designed to report information about how the computer is connected to the local network, which on the plus side means that the download button immediately disappears when you disable your network adapter, but I don't think it would be accurate in the case where a computer is networked but not connected to the internet (e.g. the user's ISP is experiencing a service outage). And in cases like mine, it fails entirely, while e.g. an HTTP request to a known server would just work.