Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the minimum version requirement of Qt to 6.4 #1928

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

xuzhen
Copy link
Contributor

@xuzhen xuzhen commented Feb 5, 2024

Describe your changes

All Qt components required by gpt4all-chat already exist in Qt 6.4, there is no need to require a minimum version of Qt 6.5. This also facilitates users to compile source code in Debian and its derivative distributions, because Qt shipped in their repositories is still 6.4.2

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Steps to Reproduce

Notes

Signed-off-by: Xu Zhen <xuzhen@users.noreply.github.com>
@xuzhen xuzhen marked this pull request as ready for review February 5, 2024 09:40
@cebtenzzre
Copy link
Member

Qt 6.5 was released nearly a year ago, and Qt 6.4 no longer receives any official support - but as long as the Debian team is supporting it, I suppose it's fine.

@manyoso manyoso merged commit 0072860 into nomic-ai:main Mar 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants