Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase of 115 #140

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Rebase of 115 #140

merged 7 commits into from
Jan 3, 2025

Conversation

JFRudzinski
Copy link
Collaborator

This is a rebase of the MR in #131

Closes #115

@JFRudzinski
Copy link
Collaborator Author

@ladinesa I made a new branch for the rebase just in case, I will merge once the tests pass and then close the corresponding other MR and issue

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12597590320

Details

  • 109 of 130 (83.85%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 88.185%
Changes Missing Coverage Covered Lines Changed/Added Lines %
atomisticparsers/asap/parser.py 17 19 89.47%
atomisticparsers/utils/parsers.py 89 108 82.41%
Totals Coverage Status
Change from base Build 12371157247: 0.009%
Covered Lines: 6337
Relevant Lines: 7186
💛 - Coveralls

@JFRudzinski JFRudzinski merged commit ad99184 into develop Jan 3, 2025
3 checks passed
@JFRudzinski JFRudzinski deleted the rebase-of-115 branch January 3, 2025 12:27
@JFRudzinski JFRudzinski mentioned this pull request Jan 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problematic parsing of *.traj files from ase
4 participants
@JFRudzinski @coveralls @schumannj @ladinesa