refactor: start using KVStoreService #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivivanov
force-pushed
the
stores_refactoring
branch
from
5c5c1f9 to
a49958f
Compare
ivivanov
force-pushed
the
stores_refactoring
branch
4 times, most recently
from
c583051 to
fd0e227
Compare
Closed
Lockwarr
reviewed
Aug 6, 2024
x/tax/keeper/msg_server.go
Outdated
| @@ -33,8 +33,8 @@ func (ms msgServer) UpdateParams(goCtx context.Context, req *types.MsgUpdatePara | |||
| return nil, errors.Wrapf(govtypes.ErrInvalidSigner, "invalid authority; expected %s, got %s", ms.authority, req.Authority) | |||
| } | |||
|
|
|||
| ctx := sdk.UnwrapSDKContext(goCtx) | |||
| if err := ms.SetParams(ctx, req.Params); err != nil { | |||
| sdkCtx := sdk.UnwrapSDKContext(ctx) | |||
There was a problem hiding this comment.
no need to unwrapSDKContext here I think
| var p types.Params | ||
| b, err := store.Get(types.ParamsKey) | ||
| if err != nil { | ||
| // TODO panic("error getting stored tax params") |
ivivanov
force-pushed
the
stores_refactoring
branch
from
fd0e227 to
a1ca02e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.