Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup network scripts update #105

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

desislavva
Copy link
Contributor

No description provided.

@desislavva desislavva requested a review from Lockwarr January 5, 2024 15:29
@ivivanov
Copy link
Collaborator

ivivanov commented Jan 8, 2024

Please follow conventional commits guide

if [[ "$COMMAND" == "$COMMAND_FULL_GEN" ]]; then
verify_mandatory "$CHAIN_ID" "Nolus chain identifier"
verify_mandatory "$ACCOUNTS_SPEC" "Nolus genesis accounts spec"
verify_mandatory "$WASM_SCRIPT_PATH" "Wasm script path"
verify_mandatory "$WASM_CODE_PATH" "Wasm code path"
verify_mandatory "$TREASURY_INIT_TOKENS_U128" "Treasury init tokens"
verify_mandatory "$VAL_NODE_URLS_AND_VAL_PUBKEYS" "Validator URLs and validator public keys spec"
verify_mandatory "$LPP_NATIVE" "Lpp native currency symbol"
verify_mandatory "$OUTPUT_FILE" "Genesis output file"
verify_mandatory "$DEX_ADMIN_MNEMONIC" "DEX-admin account mnemonic"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe optional?

README.md Outdated
```sh
osmosisd keys add hermes_key --recover
```

Initialize and start (run `./scripts/init-local-network.sh --help` for additional configuration options):

```sh
./scripts/init-local-network.sh --reserve-tokens <reserve_account_init_tokens> --hermes-mnemonic <the_mnemonic_generated_by_the_previous_steps> --dex-network-addr-rpc-host <dex_network_addr_rpc_host_part> --dex-network-addr-grpc-host <dex_network_addr_grpc_host_part> --dex-admin-mnemonic <mnemonic_phrase> --store-code-privileged-account-mnemonic <mnemonic_phrase>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dex-network-addr-rpc-host,
dex-network-addr-grpc-host
probably should be removed here as well

@desislavva desislavva force-pushed the setup-network-scripts-update branch from 33a8366 to 8816673 Compare January 8, 2024 15:55
@desislavva desislavva merged commit 40aa1ec into main Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants