streamline ansible_default_ipv4 gathering loop (kubernetes-sigs#9281)

nolimitkun · Mar 19, 2023 · 3d17b34 · 3d17b34
1 parent 0e3fade
commit 3d17b34
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/roles/kubespray-defaults/tasks/fallback_ips.yml b/roles/kubespray-defaults/tasks/fallback_ips.yml
@@ -4,13 +4,15 @@
 # Thanks https://medium.com/opsops/ansible-default-ipv4-is-not-what-you-think-edb8ab154b10
 
 - name: Gather ansible_default_ipv4 from all hosts
-  tags: always
-  include_tasks: fallback_ips_gather.yml
-  when: hostvars[delegate_host_to_gather_facts].ansible_default_ipv4 is not defined
-  loop: "{{ groups['k8s_cluster']|default([]) + groups['etcd']|default([]) + groups['calico_rr']|default([]) }}"
-  loop_control:
-    loop_var: delegate_host_to_gather_facts
+  setup:
+    gather_subset: '!all,network'
+    filter: "ansible_default_ipv4"
+  delegate_to: "{{ item }}"
+  delegate_facts: yes
+  when: hostvars[item].ansible_default_ipv4 is not defined
+  loop: "{{ (groups['k8s_cluster']|default([]) + groups['etcd']|default([]) + groups['calico_rr']|default([])) | unique }}"
   run_once: yes
+  tags: always
 
 - name: create fallback_ips_base
   set_fact:

diff --git a/roles/kubespray-defaults/tasks/fallback_ips_gather.yml b/roles/kubespray-defaults/tasks/fallback_ips_gather.yml