Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: refactor workflows #404

Merged
merged 5 commits into from
Feb 13, 2025
Merged

ci: refactor workflows #404

merged 5 commits into from
Feb 13, 2025

Conversation

northword
Copy link
Member

@northword northword commented Feb 9, 2025 •
edited
Loading

  • no need to set publish script for each package, pnpm publish -r is enough
  • sync github release in ci
  • provide PROVENANCE
  • use setup-node build-in cache
  • run test in linux and windows (ci failed because og-image: sep in windows breaks test #388, not this pr intro)

BTW, there is a lot of wasted resources in the current CI, such as.

  • push: build packages 2 times
  • pr: build packages 3 times
  • release (with push): build packages 3 times

However, there seems to be no better solution at the moment.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025 •
edited
Loading

✅ Successfully deployed to Netlify

Platform Status URL
Ubuntu Success https://67a8ca849d46fde19c4bb287--nolebase-integrations.netlify.app
Windows Success https://67a8ca8eb3b13eaf1b033fc6--nolebase-integrations.netlify.app

@northword northword marked this pull request as ready for review February 9, 2025 15:41
@nekomeowww nekomeowww merged commit d88eaf8 into main Feb 13, 2025
8 checks passed
@nekomeowww nekomeowww deleted the publish-script branch February 13, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekomeowww nekomeowww nekomeowww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@northword @nekomeowww