Update thirdparty.py for support kubernetes_asyncio. #809
Conversation
The model of the official sdk of kubernetes and the model of kubernetes_asyncio work the same. Signed-off-by: Kim Minjong <make.dirty.code@gmail.com>
Signed-off-by: Kim Minjong <make.dirty.code@gmail.com>
Signed-off-by: Kim Minjong <make.dirty.code@gmail.com>
|
This pull request introduces 1 alert when merging 248ef78 into 308e7ff - view on LGTM.com new alerts:
|
|
Hi, is there any timeline on when this change will be merged? I had to use the V1Secret object from official k8s python client instead of the object provided by kubernetes_asyncio since the |
|
We also need this feature |
|
Sorry, but why this MR was closed? |
|
Let’s keep it open so that it remains in my attention. The nearest release is expected to happen with Python 3.12 support once the last blocker (iohttp) is released: #1067; plus all easy prs combined (and retested) in a single batch. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| V1ObjectMeta = V1OwnerReference = None | ||
|
|
||
| try: | ||
| from kubernetes_asyncio.client import V1ObjectMeta as V1ObjectMeta, V1OwnerReference as V1OwnerReference |
Check notice
Code scanning / CodeQL
Unused import Note
|
|
||
| try: | ||
| from kubernetes_asyncio.client import V1ObjectMeta as V1ObjectMeta, V1OwnerReference as V1OwnerReference | ||
| except ImportError: |
Check notice
Code scanning / CodeQL
Empty except Note
The model of the official sdk of kubernetes and the model of kubernetes_asyncio work the same. So we can support the model in the same way.
closes: #806