Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set CURRENT_TIMESTAMP to expires default #4

Merged
merged 2 commits into from
Jan 9, 2018

Conversation

tksmrkm
Copy link
Contributor

@tksmrkm tksmrkm commented Dec 28, 2017

MySQL@5.7.18でmigrations migrateしたところ
Syntax error or access violation: 1067 Invalid default value for 'expires'
と出ました。
timestampに、not null, default nullが許可されないようなのでdefaultに明示的にCURRENT_TIMESTAMPを指定しました。

@codecov
Copy link

codecov bot commented Dec 28, 2017

Codecov Report

Merging #4 into master will increase coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
+ Coverage     94.91%   95.37%   +0.46%     
  Complexity       53       53              
============================================
  Files             2        2              
  Lines           177      173       -4     
============================================
- Hits            168      165       -3     
+ Misses            9        8       -1
Impacted Files Coverage Δ Complexity Δ
src/Model/Table/RememberMeTokensTable.php 100% <0%> (ø) 6% <0%> (ø) ⬇️
src/Auth/CookieAuthenticate.php 94.36% <0%> (+0.57%) 47% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1081b0...939da87. Read the comment docs.

@nojimage
Copy link
Owner

CURRENT_TIMESTAMP では現在のデフォルト値と異なってしまいますので、0000-00-00 00:00:00 をセットするようにできますか?

@nojimage nojimage merged commit 74097fb into nojimage:master Jan 9, 2018
@nojimage
Copy link
Owner

nojimage commented Jan 9, 2018

Thanks!

nojimage added a commit that referenced this pull request Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants