Skip reset.conf if we processed PlatformConfig del #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomflynn
reviewed
Jul 23, 2024
tomflynn
approved these changes
Jul 23, 2024
There are 2 scenarios 1. reset.conf comes immediately after PlatformConfig delete We will skip processing it if within a certain time, 5 secs default This is so we do not trigger a disconnect twice for the same event, one via PlatformConfig delete and other via reset.conf 2. PlatformConfig delete comes after reset.conf This should not be an issue since we will not be able to get the PlatformConfig event once the connection has been reset via reset.conf processing. There is a small race here and in that worst case we may process the event twice but the window is significantly reduced. Signed-off-by: Madhu Challa <challa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 scenarios
reset.conf comes immediately after PlatformConfig delete We will skip processing it if within a certain time, 5 secs default This is so we do not trigger a disconnect twice for the same event, one via PlatformConfig delete and other via reset.conf
PlatformConfig delete comes after reset.conf This should not be an issue since we will not be able to get the PlatformConfig event once the connection has been reset via reset.conf processing. There is a small race here and in that worst case we may process the event twice but the window is significantly reduced.