Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable startuppol on error, fix switch sync delay #575

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

mchalla
Copy link
Contributor

@mchalla mchalla commented Jul 8, 2024

As an optimization turn off startup policy if the read fails for any reason or if 0 objects are read

Also switch sync delay may not be reliable if the config file that enables it is read after renderer config. Fix it by reading the value before using it (set in constructor)

@mchalla
Copy link
Contributor Author

mchalla commented Jul 8, 2024

Looks like one of the test depends on the timeout being 0. I am fixing it now.

As an optimization turn off startup policy if the read fails
for any reason or if 0 objects are read

Also switch sync delay may not be reliable if the config file
that enables it is read after renderer config. Fix it by reading
the value before using it (set in constructor)

Signed-off-by: Madhu Challa <challa@gmail.com>
@coveralls
Copy link
Collaborator

coveralls commented Jul 8, 2024

Coverage Status

coverage: 78.775% (-0.002%) from 78.777%
when pulling 463fb24 on opflex-fixes
into 43cc55a on master.

@mchalla mchalla merged commit efa3d40 into master Jul 8, 2024
5 checks passed
@mchalla mchalla deleted the opflex-fixes branch July 8, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants