Fix exception with stoul for droppruning #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchalla
approved these changes
Jun 27, 2024
shastrinator
force-pushed
the
fix_dropprunecore
branch
2 times, most recently
from
6f90903
to
f728699
Compare
When src/dst prefix lengths were unset, fields contained an empty space, which was inadvertently added while parsing for mask, which caused an exception in opflex_agent Signed-off-by: Kiran Shastri <shastrinator@gmail.com>
shastrinator
force-pushed
the
fix_dropprunecore
branch
from
f728699
to
cf54871
Compare
tbachman
reviewed
Jun 28, 2024
| } | ||
| boost::system::error_code ec; | ||
| addr = asio::ip::address::from_string(address_string, ec); | ||
| if (ec) { | ||
| LOG(ERROR) << "Invalid address for filter " << filter_idx; | ||
| return -1; | ||
| } | ||
| if(pfxLen) { | ||
| if(!pfxLenArg.empty()) { | ||
| LOG(INFO) << "PrefixLen is set!"; |
There was a problem hiding this comment.
I realize that this is already merged, but do we feel that this should be an INFO level log?
There was a problem hiding this comment.
No doesn't need to be, missed removing it post debug. Can be removed with some later commit. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When src/dst prefix lengths were unset, fields
contained an empty space, which was inadvertently added while parsing for mask, which caused an
exception in opflex_agent