Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve proptesting of 128bit values in noirc_abi #7485

Merged
merged 1 commit into from
Feb 21, 2025
Merged

chore: improve proptesting of 128bit values in noirc_abi #7485

merged 1 commit into from
Feb 21, 2025

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

We had a few locations where pushing u128s or i128s through the abi encoder would result in incorrect results. This PR
fixes those and expands the abi encoder's proptesting to cover these types.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from asterite February 21, 2025 16:48
@TomAFrench TomAFrench added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit 1dfe472 Feb 21, 2025
102 checks passed
@TomAFrench TomAFrench deleted the tf/extend-abi-fuzzing-to-cover-128-bit-values branch February 21, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @asterite