-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Only lock the packages selected in the workspace #7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Feb 11, 2025
asterite
reviewed
Feb 11, 2025
asterite
reviewed
Feb 11, 2025
asterite
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactor, looks good!
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 12, 2025
…ir#7347) chore: Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341) fix(cli): Only lock the packages selected in the workspace (noir-lang/noir#7345) chore: remove some unused types and functions in the AST (noir-lang/noir#7339) chore: remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337) chore(ci): Add Vecs and vecs to cspell (noir-lang/noir#7342) chore: redo typo PR by osrm (noir-lang/noir#7238) chore: Release Noir(1.0.0-beta.2) (noir-lang/noir#6914) fix: lock git dependencies folder when resolving workspace (noir-lang/noir#7327) fix: perform SSA constraints check on final SSA (noir-lang/noir#7334) chore: remove misleading output from `nargo check` (noir-lang/noir#7329) chore: fix warnings (noir-lang/noir#7330) chore: normalize path displayed by `nargo new` (noir-lang/noir#7328) chore: split acirgen into multiple modules (noir-lang/noir#7310) chore: remove unnecessary constants (noir-lang/noir#7326)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 12, 2025
chore: Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341) fix(cli): Only lock the packages selected in the workspace (noir-lang/noir#7345) chore: remove some unused types and functions in the AST (noir-lang/noir#7339) chore: remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337) chore(ci): Add Vecs and vecs to cspell (noir-lang/noir#7342) chore: redo typo PR by osrm (noir-lang/noir#7238) chore: Release Noir(1.0.0-beta.2) (noir-lang/noir#6914) fix: lock git dependencies folder when resolving workspace (noir-lang/noir#7327) fix: perform SSA constraints check on final SSA (noir-lang/noir#7334) chore: remove misleading output from `nargo check` (noir-lang/noir#7329) chore: fix warnings (noir-lang/noir#7330) chore: normalize path displayed by `nargo new` (noir-lang/noir#7328) chore: split acirgen into multiple modules (noir-lang/noir#7310) chore: remove unnecessary constants (noir-lang/noir#7326)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 13, 2025
…#7358) feat(performance): Check sub operations against induction variables (noir-lang/noir#7356) chore: avoid doing all brillig integer arithmetic on u128s (noir-lang/noir#7357) feat(cli): Add `--target-dir` option (noir-lang/noir#7350) fix(ssa): Make the lookback feature opt-in (noir-lang/noir#7190) feat(performance): Use unchecked ops based upon known induction variables (noir-lang/noir#7344) chore: mark sha256 as deprecated from the stdlib (noir-lang/noir#7351) fix: incorrect secondary file in LSP errors (noir-lang/noir#7347) chore: Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341) fix(cli): Only lock the packages selected in the workspace (noir-lang/noir#7345) chore: remove some unused types and functions in the AST (noir-lang/noir#7339) chore: remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337) chore(ci): Add Vecs and vecs to cspell (noir-lang/noir#7342) chore: redo typo PR by osrm (noir-lang/noir#7238) chore: Release Noir(1.0.0-beta.2) (noir-lang/noir#6914) fix: lock git dependencies folder when resolving workspace (noir-lang/noir#7327) fix: perform SSA constraints check on final SSA (noir-lang/noir#7334) chore: remove misleading output from `nargo check` (noir-lang/noir#7329) chore: fix warnings (noir-lang/noir#7330) chore: normalize path displayed by `nargo new` (noir-lang/noir#7328) chore: split acirgen into multiple modules (noir-lang/noir#7310) chore: remove unnecessary constants (noir-lang/noir#7326)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 13, 2025
feat(performance): Check sub operations against induction variables (noir-lang/noir#7356) chore: avoid doing all brillig integer arithmetic on u128s (noir-lang/noir#7357) feat(cli): Add `--target-dir` option (noir-lang/noir#7350) fix(ssa): Make the lookback feature opt-in (noir-lang/noir#7190) feat(performance): Use unchecked ops based upon known induction variables (noir-lang/noir#7344) chore: mark sha256 as deprecated from the stdlib (noir-lang/noir#7351) fix: incorrect secondary file in LSP errors (noir-lang/noir#7347) chore: Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341) fix(cli): Only lock the packages selected in the workspace (noir-lang/noir#7345) chore: remove some unused types and functions in the AST (noir-lang/noir#7339) chore: remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337) chore(ci): Add Vecs and vecs to cspell (noir-lang/noir#7342) chore: redo typo PR by osrm (noir-lang/noir#7238) chore: Release Noir(1.0.0-beta.2) (noir-lang/noir#6914) fix: lock git dependencies folder when resolving workspace (noir-lang/noir#7327) fix: perform SSA constraints check on final SSA (noir-lang/noir#7334) chore: remove misleading output from `nargo check` (noir-lang/noir#7329) chore: fix warnings (noir-lang/noir#7330) chore: normalize path displayed by `nargo new` (noir-lang/noir#7328) chore: split acirgen into multiple modules (noir-lang/noir#7310) chore: remove unnecessary constants (noir-lang/noir#7326)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 13, 2025
feat: `FunctionDefinition::as_typed_expr` (noir-lang/noir#7358) feat(performance): Check sub operations against induction variables (noir-lang/noir#7356) chore: avoid doing all brillig integer arithmetic on u128s (noir-lang/noir#7357) feat(cli): Add `--target-dir` option (noir-lang/noir#7350) fix(ssa): Make the lookback feature opt-in (noir-lang/noir#7190) feat(performance): Use unchecked ops based upon known induction variables (noir-lang/noir#7344) chore: mark sha256 as deprecated from the stdlib (noir-lang/noir#7351) fix: incorrect secondary file in LSP errors (noir-lang/noir#7347) chore: Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341) fix(cli): Only lock the packages selected in the workspace (noir-lang/noir#7345) chore: remove some unused types and functions in the AST (noir-lang/noir#7339) chore: remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337) chore(ci): Add Vecs and vecs to cspell (noir-lang/noir#7342) chore: redo typo PR by osrm (noir-lang/noir#7238) chore: Release Noir(1.0.0-beta.2) (noir-lang/noir#6914) fix: lock git dependencies folder when resolving workspace (noir-lang/noir#7327) fix: perform SSA constraints check on final SSA (noir-lang/noir#7334) chore: remove misleading output from `nargo check` (noir-lang/noir#7329) chore: fix warnings (noir-lang/noir#7330) chore: normalize path displayed by `nargo new` (noir-lang/noir#7328) chore: split acirgen into multiple modules (noir-lang/noir#7310) chore: remove unnecessary constants (noir-lang/noir#7326)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 13, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: deprecate keccak256 (noir-lang/noir#7361) feat: `FunctionDefinition::as_typed_expr` (noir-lang/noir#7358) feat(performance): Check sub operations against induction variables (noir-lang/noir#7356) chore: avoid doing all brillig integer arithmetic on u128s (noir-lang/noir#7357) feat(cli): Add `--target-dir` option (noir-lang/noir#7350) fix(ssa): Make the lookback feature opt-in (noir-lang/noir#7190) feat(performance): Use unchecked ops based upon known induction variables (noir-lang/noir#7344) chore: mark sha256 as deprecated from the stdlib (noir-lang/noir#7351) fix: incorrect secondary file in LSP errors (noir-lang/noir#7347) chore: Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341) fix(cli): Only lock the packages selected in the workspace (noir-lang/noir#7345) chore: remove some unused types and functions in the AST (noir-lang/noir#7339) chore: remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337) chore(ci): Add Vecs and vecs to cspell (noir-lang/noir#7342) chore: redo typo PR by osrm (noir-lang/noir#7238) chore: Release Noir(1.0.0-beta.2) (noir-lang/noir#6914) fix: lock git dependencies folder when resolving workspace (noir-lang/noir#7327) fix: perform SSA constraints check on final SSA (noir-lang/noir#7334) chore: remove misleading output from `nargo check` (noir-lang/noir#7329) chore: fix warnings (noir-lang/noir#7330) chore: normalize path displayed by `nargo new` (noir-lang/noir#7328) chore: split acirgen into multiple modules (noir-lang/noir#7310) chore: remove unnecessary constants (noir-lang/noir#7326) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Tom French <tom@tomfren.ch>
sklppy88
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 13, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.76.4</summary> ## [0.76.4](aztec-package-v0.76.3...aztec-package-v0.76.4) (2025-02-13) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.76.4</summary> ## [0.76.4](barretenberg.js-v0.76.3...barretenberg.js-v0.76.4) (2025-02-13) ### Miscellaneous * Unify webpack dev server versions ([#11965](#11965)) ([921d2cd](921d2cd)) </details> <details><summary>aztec-packages: 0.76.4</summary> ## [0.76.4](aztec-packages-v0.76.3...aztec-packages-v0.76.4) (2025-02-13) ### Features * `FunctionDefinition::as_typed_expr` (noir-lang/noir#7358) ([5efdd57](5efdd57)) * Aes decryption oracle ([#11907](#11907)) ([c4ce913](c4ce913)) * **avm:** Constrained ec_add ([#11525](#11525)) ([f8fe602](f8fe602)) * **avm:** Interaction testing ([#11947](#11947)) ([fc647eb](fc647eb)) * **avm:** Relation microbenchmarks ([#11974](#11974)) ([95b581d](95b581d)) * **cli:** Add `--target-dir` option (noir-lang/noir#7350) ([5efdd57](5efdd57)) * Indexed protocol contracts tree ([#11897](#11897)) ([96e84d4](96e84d4)) * **performance:** Check sub operations against induction variables (noir-lang/noir#7356) ([5efdd57](5efdd57)) * **performance:** Use unchecked ops based upon known induction variables (noir-lang/noir#7344) ([5efdd57](5efdd57)) * Small blob fixes/improvements ([#11686](#11686)) ([4eab9fc](4eab9fc)) * Update fee model ([#11953](#11953)) ([2798d58](2798d58)) * Use brillig optimized sha256 ([#11696](#11696)) ([438c905](438c905)) ### Bug Fixes * Ci fixes ([#11973](#11973)) ([6386f4e](6386f4e)) * **cli:** Only lock the packages selected in the workspace (noir-lang/noir#7345) ([5efdd57](5efdd57)) * Deterministic generation of vkeys in ts ([#11951](#11951)) ([7901cac](7901cac)) * Incorrect secondary file in LSP errors (noir-lang/noir#7347) ([5efdd57](5efdd57)) * Lock git dependencies folder when resolving workspace (noir-lang/noir#7327) ([5efdd57](5efdd57)) * Perform SSA constraints check on final SSA (noir-lang/noir#7334) ([5efdd57](5efdd57)) * Remove deprecated artifacts ([#11979](#11979)) ([4f0dce7](4f0dce7)) * Remove serial queue in broker facade ([#11956](#11956)) ([3485b52](3485b52)) * **ssa:** Make the lookback feature opt-in (noir-lang/noir#7190) ([5efdd57](5efdd57)) ### Miscellaneous * **avm:** Tracegen interactions assertion ([#11972](#11972)) ([b865ccc](b865ccc)) * Avoid doing all brillig integer arithmetic on u128s (noir-lang/noir#7357) ([5efdd57](5efdd57)) * Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341) ([5efdd57](5efdd57)) * Bump devnet boot node resources ([#11958](#11958)) ([bbcdefc](bbcdefc)) * **ci:** Add Vecs and vecs to cspell (noir-lang/noir#7342) ([5efdd57](5efdd57)) * Deprecate keccak256 (noir-lang/noir#7361) ([5efdd57](5efdd57)) * Fix warnings (noir-lang/noir#7330) ([5efdd57](5efdd57)) * Mark sha256 as deprecated from the stdlib (noir-lang/noir#7351) ([5efdd57](5efdd57)) * Moving storage slot out of `NoteHeader` ([#11904](#11904)) ([8c4bb1c](8c4bb1c)) * Normalize path displayed by `nargo new` (noir-lang/noir#7328) ([5efdd57](5efdd57)) * Redo typo PR by osrm (noir-lang/noir#7238) ([5efdd57](5efdd57)) * Release Noir(1.0.0-beta.2) (noir-lang/noir#6914) ([5efdd57](5efdd57)) * Remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337) ([5efdd57](5efdd57)) * Remove misleading output from `nargo check` (noir-lang/noir#7329) ([5efdd57](5efdd57)) * Remove some unused types and functions in the AST (noir-lang/noir#7339) ([5efdd57](5efdd57)) * Remove unnecessary constants (noir-lang/noir#7326) ([5efdd57](5efdd57)) * Revive browser test before killing it ([#11964](#11964)) ([cb47cc0](cb47cc0)) * Split acirgen into multiple modules (noir-lang/noir#7310) ([5efdd57](5efdd57)) * Unify webpack dev server versions ([#11965](#11965)) ([921d2cd](921d2cd)) </details> <details><summary>barretenberg: 0.76.4</summary> ## [0.76.4](barretenberg-v0.76.3...barretenberg-v0.76.4) (2025-02-13) ### Features * Aes decryption oracle ([#11907](#11907)) ([c4ce913](c4ce913)) * **avm:** Constrained ec_add ([#11525](#11525)) ([f8fe602](f8fe602)) * **avm:** Interaction testing ([#11947](#11947)) ([fc647eb](fc647eb)) * **avm:** Relation microbenchmarks ([#11974](#11974)) ([95b581d](95b581d)) ### Miscellaneous * **avm:** Tracegen interactions assertion ([#11972](#11972)) ([b865ccc](b865ccc)) * Unify webpack dev server versions ([#11965](#11965)) ([921d2cd](921d2cd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Feb 14, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.76.4</summary> ## [0.76.4](AztecProtocol/aztec-packages@aztec-package-v0.76.3...aztec-package-v0.76.4) (2025-02-13) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.76.4</summary> ## [0.76.4](AztecProtocol/aztec-packages@barretenberg.js-v0.76.3...barretenberg.js-v0.76.4) (2025-02-13) ### Miscellaneous * Unify webpack dev server versions ([#11965](AztecProtocol/aztec-packages#11965)) ([921d2cd](AztecProtocol/aztec-packages@921d2cd)) </details> <details><summary>aztec-packages: 0.76.4</summary> ## [0.76.4](AztecProtocol/aztec-packages@aztec-packages-v0.76.3...aztec-packages-v0.76.4) (2025-02-13) ### Features * `FunctionDefinition::as_typed_expr` (noir-lang/noir#7358) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Aes decryption oracle ([#11907](AztecProtocol/aztec-packages#11907)) ([c4ce913](AztecProtocol/aztec-packages@c4ce913)) * **avm:** Constrained ec_add ([#11525](AztecProtocol/aztec-packages#11525)) ([f8fe602](AztecProtocol/aztec-packages@f8fe602)) * **avm:** Interaction testing ([#11947](AztecProtocol/aztec-packages#11947)) ([fc647eb](AztecProtocol/aztec-packages@fc647eb)) * **avm:** Relation microbenchmarks ([#11974](AztecProtocol/aztec-packages#11974)) ([95b581d](AztecProtocol/aztec-packages@95b581d)) * **cli:** Add `--target-dir` option (noir-lang/noir#7350) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Indexed protocol contracts tree ([#11897](AztecProtocol/aztec-packages#11897)) ([96e84d4](AztecProtocol/aztec-packages@96e84d4)) * **performance:** Check sub operations against induction variables (noir-lang/noir#7356) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * **performance:** Use unchecked ops based upon known induction variables (noir-lang/noir#7344) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Small blob fixes/improvements ([#11686](AztecProtocol/aztec-packages#11686)) ([4eab9fc](AztecProtocol/aztec-packages@4eab9fc)) * Update fee model ([#11953](AztecProtocol/aztec-packages#11953)) ([2798d58](AztecProtocol/aztec-packages@2798d58)) * Use brillig optimized sha256 ([#11696](AztecProtocol/aztec-packages#11696)) ([438c905](AztecProtocol/aztec-packages@438c905)) ### Bug Fixes * Ci fixes ([#11973](AztecProtocol/aztec-packages#11973)) ([6386f4e](AztecProtocol/aztec-packages@6386f4e)) * **cli:** Only lock the packages selected in the workspace (noir-lang/noir#7345) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Deterministic generation of vkeys in ts ([#11951](AztecProtocol/aztec-packages#11951)) ([7901cac](AztecProtocol/aztec-packages@7901cac)) * Incorrect secondary file in LSP errors (noir-lang/noir#7347) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Lock git dependencies folder when resolving workspace (noir-lang/noir#7327) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Perform SSA constraints check on final SSA (noir-lang/noir#7334) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Remove deprecated artifacts ([#11979](AztecProtocol/aztec-packages#11979)) ([4f0dce7](AztecProtocol/aztec-packages@4f0dce7)) * Remove serial queue in broker facade ([#11956](AztecProtocol/aztec-packages#11956)) ([3485b52](AztecProtocol/aztec-packages@3485b52)) * **ssa:** Make the lookback feature opt-in (noir-lang/noir#7190) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) ### Miscellaneous * **avm:** Tracegen interactions assertion ([#11972](AztecProtocol/aztec-packages#11972)) ([b865ccc](AztecProtocol/aztec-packages@b865ccc)) * Avoid doing all brillig integer arithmetic on u128s (noir-lang/noir#7357) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Bump devnet boot node resources ([#11958](AztecProtocol/aztec-packages#11958)) ([bbcdefc](AztecProtocol/aztec-packages@bbcdefc)) * **ci:** Add Vecs and vecs to cspell (noir-lang/noir#7342) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Deprecate keccak256 (noir-lang/noir#7361) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Fix warnings (noir-lang/noir#7330) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Mark sha256 as deprecated from the stdlib (noir-lang/noir#7351) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Moving storage slot out of `NoteHeader` ([#11904](AztecProtocol/aztec-packages#11904)) ([8c4bb1c](AztecProtocol/aztec-packages@8c4bb1c)) * Normalize path displayed by `nargo new` (noir-lang/noir#7328) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Redo typo PR by osrm (noir-lang/noir#7238) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Release Noir(1.0.0-beta.2) (noir-lang/noir#6914) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Remove misleading output from `nargo check` (noir-lang/noir#7329) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Remove some unused types and functions in the AST (noir-lang/noir#7339) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Remove unnecessary constants (noir-lang/noir#7326) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Revive browser test before killing it ([#11964](AztecProtocol/aztec-packages#11964)) ([cb47cc0](AztecProtocol/aztec-packages@cb47cc0)) * Split acirgen into multiple modules (noir-lang/noir#7310) ([5efdd57](AztecProtocol/aztec-packages@5efdd57)) * Unify webpack dev server versions ([#11965](AztecProtocol/aztec-packages#11965)) ([921d2cd](AztecProtocol/aztec-packages@921d2cd)) </details> <details><summary>barretenberg: 0.76.4</summary> ## [0.76.4](AztecProtocol/aztec-packages@barretenberg-v0.76.3...barretenberg-v0.76.4) (2025-02-13) ### Features * Aes decryption oracle ([#11907](AztecProtocol/aztec-packages#11907)) ([c4ce913](AztecProtocol/aztec-packages@c4ce913)) * **avm:** Constrained ec_add ([#11525](AztecProtocol/aztec-packages#11525)) ([f8fe602](AztecProtocol/aztec-packages@f8fe602)) * **avm:** Interaction testing ([#11947](AztecProtocol/aztec-packages#11947)) ([fc647eb](AztecProtocol/aztec-packages@fc647eb)) * **avm:** Relation microbenchmarks ([#11974](AztecProtocol/aztec-packages#11974)) ([95b581d](AztecProtocol/aztec-packages@95b581d)) ### Miscellaneous * **avm:** Tracegen interactions assertion ([#11972](AztecProtocol/aztec-packages#11972)) ([b865ccc](AztecProtocol/aztec-packages@b865ccc)) * Unify webpack dev server versions ([#11965](AztecProtocol/aztec-packages#11965)) ([921d2cd](AztecProtocol/aztec-packages@921d2cd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
TomAFrench
added a commit
that referenced
this pull request
Feb 14, 2025
* master: (42 commits) fix: give "correct" error when trying to use AsTraitPath (#7360) chore: avoid u128s in brillig memory (#7363) chore: update docs about integer overflows (#7370) fix!: Only decrement the counter of an array if its address has not changed (#7297) fix: let LSP read `noirfmt.toml` for formatting files (#7355) chore: deprecate keccak256 (#7361) feat: `FunctionDefinition::as_typed_expr` (#7358) feat(performance): Check sub operations against induction variables (#7356) chore: avoid doing all brillig integer arithmetic on u128s (#7357) feat(cli): Add `--target-dir` option (#7350) fix(ssa): Make the lookback feature opt-in (#7190) feat(performance): Use unchecked ops based upon known induction variables (#7344) chore: mark sha256 as deprecated from the stdlib (#7351) fix: incorrect secondary file in LSP errors (#7347) chore: Basic test for MSM in Noir to catch performance improvements and regressions (#7341) fix(cli): Only lock the packages selected in the workspace (#7345) chore: remove some unused types and functions in the AST (#7339) chore: remove foreign calls array from Brillig VM constructor (#7337) chore(ci): Add Vecs and vecs to cspell (#7342) chore: redo typo PR by osrm (#7238) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Related to #7335
Summary*
Changes the
nargo
CLI to take out individual locks on the packages affected by the commands, rather than the workspace levelNargo.toml
file, so that we can execute commands in parallel.Also fixes the issue where the
target
changed depending on whether we use--package
to select a member in the workspace or whether wecd
into the directory of the member itself. We always want it to be the workspace level target.Additional Context
#6752 changed the CLI to look for the first package on the ancestor path when neither
--workspace
nor--package
options were present, and treat that as theWorkspace
, which resulted in thetarget
directory being different in the two cases. Now we always look for the top levelNargo.toml
, ie. the workspace, so that we use the correcttarget
. We look for both the top and bottom level workspaces; if they differ, then we consider the bottom one as the selected member.#6941 moved the locks from the integration tests into
nargo
itself, where it was easier to manage, however it interfered with the CI scripts usingparallel
to run CLI commands concurrently because the lock was taken out on the entire workspace.Testing
Here's a session demonstrating that indeed on
master
if we execute a member the artefacts are saved in its owntarget
directory, whereas on this branch they go into the workspace level one (note how different packages write to different output files in the common directory, so they don't conflict):Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.