Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssa refactor): Add optimization and transformation pass to Circuit #1435

Merged
merged 1 commit into from
May 30, 2023
Merged

chore(ssa refactor): Add optimization and transformation pass to Circuit #1435

merged 1 commit into from
May 30, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Until #1394 is merged, we need to include the optimization and transformation pass after we have generated the ACIR bytecode.

Problem*

Resolves

Summary*

This PR sets out to

Example

Before:

After:

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray mentioned this pull request May 29, 2023
Merged
5 tasks
joss-aztec
joss-aztec approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@joss-aztec joss-aztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevaundray kevaundray added this pull request to the merge queue May 30, 2023
Merged via the queue into master with commit 8a9e995 May 30, 2023
@kevaundray kevaundray deleted the kw/add-optimized-circuit branch May 30, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joss-aztec joss-aztec joss-aztec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevaundray @joss-aztec