Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Targets #139

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Implement Targets #139

merged 5 commits into from
Nov 14, 2023

Conversation

zprobst
Copy link
Member

@zprobst zprobst commented Nov 13, 2023

Implements the feature described in #138

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (431efed) 94.51% compared to head (441626c) 94.52%.

Files Patch % Lines
nodestream/cli/operations/run_pipeline.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   94.51%   94.52%           
=======================================
  Files         122      123    +1     
  Lines        3211     3234   +23     
=======================================
+ Hits         3035     3057   +22     
- Misses        176      177    +1     
Flag Coverage Δ
3.10-macos-latest 94.52% <96.55%> (+<0.01%) ⬆️
3.10-ubuntu-latest 94.52% <96.55%> (+<0.01%) ⬆️
3.10-windows-latest 94.38% <96.29%> (+<0.01%) ⬆️
3.11-macos-latest 94.52% <96.55%> (+<0.01%) ⬆️
3.11-ubuntu-latest 94.52% <96.55%> (+<0.01%) ⬆️
3.11-windows-latest 94.38% <96.29%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zprobst zprobst marked this pull request as ready for review November 13, 2023 23:36
@zprobst zprobst requested a review from ccloes as a code owner November 13, 2023 23:36
@zprobst zprobst merged commit ce1e4ab into main Nov 14, 2023
8 checks passed
@zprobst zprobst deleted the feature/targets branch November 14, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants