Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options to disable apoc_iterate #136

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

grantleehoffman
Copy link
Contributor

  • Add option to disable apoc_iterate in neo4j connector

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a5e8db) 94.51% compared to head (8292240) 94.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         122      122           
  Lines        3208     3211    +3     
=======================================
+ Hits         3032     3035    +3     
  Misses        176      176           
Flag Coverage Δ
3.10-macos-latest 94.51% <100.00%> (+<0.01%) ⬆️
3.10-ubuntu-latest 94.51% <100.00%> (+<0.01%) ⬆️
3.10-windows-latest 94.38% <100.00%> (+<0.01%) ⬆️
3.11-macos-latest 94.51% <100.00%> (+<0.01%) ⬆️
3.11-ubuntu-latest 94.51% <100.00%> (+<0.01%) ⬆️
3.11-windows-latest 94.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nodestream/databases/neo4j/database_connector.py 52.63% <ø> (ø)
nodestream/databases/neo4j/ingest_query_builder.py 100.00% <100.00%> (ø)
nodestream/databases/neo4j/query.py 100.00% <100.00%> (ø)
nodestream/databases/neo4j/query_executor.py 95.12% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nodestream/databases/neo4j/query.py Show resolved Hide resolved
nodestream/databases/neo4j/query.py Outdated Show resolved Hide resolved
zprobst
zprobst previously approved these changes Nov 8, 2023
Copy link
Member

@zprobst zprobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

nodestream/databases/neo4j/extractor.py Outdated Show resolved Hide resolved
@grantleehoffman grantleehoffman merged commit 431efed into main Nov 13, 2023
@grantleehoffman grantleehoffman deleted the feature/option_to_disable_apoch_iterate branch November 13, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants