Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended min Node.js version #528

Merged
merged 1 commit into from Sep 15, 2016
Merged

Add recommended min Node.js version #528

merged 1 commit into from Sep 15, 2016

Conversation

ghost
Copy link

@ghost ghost commented Sep 15, 2016

Node.js version 'recommended for most users' is currently v4.5.0 LTS. Workshopper menu selection bug (see Node.js issue #5384) fixed in v6.2.0, so current version is recommended for NodeSchool users.

Node.js version 'recommended for most users' is currently v4.5.0 LTS. Workshopper menu selection bug (see Node.js issue [#5384](nodejs/node#5384)) fixed in v6.2.0, so current version is recommended for NodeSchool users.
@martinheidegger
Copy link
Contributor

@codemacabre Thank you for contributing! The version 6.0.2 is certainly not a bad idea. However: I feel that this recommendation should be reasoning somehow the Node.js version. Currently 4.5.0 is the LTS (read: stable) version and it seems weird if NodeSchool recommends something to not-use, right? (Will his problem be gone once Node 6 becomes LTS?) Do you think it would make sense to put a link in to the mention that explains why that version is important? Can we make it somehow dynamic? So that it automatically recommends the last LTS version/last development version?

@ghost
Copy link
Author

ghost commented Sep 15, 2016

@martinheidegger I agree that there should be some explanation for the version recommendation, especially as it's different from Node.js' recommended version, but any explanation should probably be kept as simple as possible to avoid overwhelming or confusing beginners.

As the bug only seems to appear on Windows (as far as I've found), and it's inconsistent, perhaps instead of blanket-recommending v6.2.0 to all users, maybe a link to troubleshooting section at the bottom of 'Get Going' could be added instead which references this issue with the solution being to update Node.js version?

@martinheidegger martinheidegger merged commit 0e1bfae into nodeschool:source Sep 15, 2016
@martinheidegger
Copy link
Contributor

I merged the PR for now but I hope you can find the time to improve it.

@ghost
Copy link
Author

ghost commented Sep 15, 2016

I'm happy to (although I'm reaching the limits of my knowledge of Git / PR protocol; apologies if I blunder)! I've adjusted the text to make it more useful as a separate paragraph; I'll send a new PR now.

@ghost ghost mentioned this pull request Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants