Correctly identifies muslc distributions #732
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we always download the official linux binaries for GNU libc even in systems with different libcs, like alpine. This is a bug, nodejs supports being compiled against muslc and has basic support for pre-compiled binaries. Support for pre-compiled binaries will be added in a different commit
|
Thank you! I'm going to spend some time with this soon. Any chance you would be up for adding some tests for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always download the official linux binaries for GNU libc even in systems with different libcs, like alpine. This is a bug, nodejs supports being compiled against muslc and has basic support for pre-compiled binaries.
Support for pre-compiled binaries will be added in a different commit
Related to #722