Revert of Fix compiler warnings on "make android_arm" (patchset #1 id…

…:1 of https://codereview.chromium.org/2264283007/ )

Reason for revert:
Speculative revert because of roll blocker https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/2241

Original issue's description:
> Fix compiler warnings on "make android_arm"
>
> Committed: https://crrev.com/3e809a6129d0097529c885579ac46e4acf4e99f6
> Cr-Commit-Position: refs/heads/master@{#38937}

TBR=bmeurer@chromium.org,jkummerow@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2286163002
Cr-Commit-Position: refs/heads/master@{#38961}

gypfiles/standalone.gypi

@@ -378,9 +378,6 @@
         'arm_version%': '<(arm_version)',
         'host_os%': '<(host_os)',
 
-        # Print to stdout on Android.
-        'v8_android_log_stdout%': 1,
-
         'conditions': [
           ['android_ndk_root==""', {
             'variables': {

src/compiler/js-operator.cc

@@ -376,7 +376,7 @@ const CreateLiteralParameters& CreateLiteralParametersOf(const Operator* op) {
   return OpParameter<CreateLiteralParameters>(op);
 }
 
-BinaryOperationHint BinaryOperationHintOf(const Operator* op) {
+const BinaryOperationHint BinaryOperationHintOf(const Operator* op) {
   DCHECK(op->opcode() == IrOpcode::kJSBitwiseOr ||
          op->opcode() == IrOpcode::kJSBitwiseXor ||
          op->opcode() == IrOpcode::kJSBitwiseAnd ||
@@ -391,7 +391,7 @@ BinaryOperationHint BinaryOperationHintOf(const Operator* op) {
   return OpParameter<BinaryOperationHint>(op);
 }
 
-CompareOperationHint CompareOperationHintOf(const Operator* op) {
+const CompareOperationHint CompareOperationHintOf(const Operator* op) {
   DCHECK(op->opcode() == IrOpcode::kJSEqual ||
          op->opcode() == IrOpcode::kJSNotEqual ||
          op->opcode() == IrOpcode::kJSStrictEqual ||

src/compiler/js-operator.h

@@ -374,9 +374,9 @@ std::ostream& operator<<(std::ostream&, CreateLiteralParameters const&);
 
 const CreateLiteralParameters& CreateLiteralParametersOf(const Operator* op);
 
-BinaryOperationHint BinaryOperationHintOf(const Operator* op);
+const BinaryOperationHint BinaryOperationHintOf(const Operator* op);
 
-CompareOperationHint CompareOperationHintOf(const Operator* op);
+const CompareOperationHint CompareOperationHintOf(const Operator* op);
 
 // Interface for building JavaScript-level operators, e.g. directly from the
 // AST. Most operators have no parameters, thus can be globally shared for all

src/deoptimize-reason.cc

@@ -23,7 +23,7 @@ size_t hash_value(DeoptimizeReason reason) {
   return static_cast<uint8_t>(reason);
 }
 
-char const* DeoptimizeReasonToString(DeoptimizeReason reason) {
+char const* const DeoptimizeReasonToString(DeoptimizeReason reason) {
   static char const* kDeoptimizeReasonStrings[] = {
 #define DEOPTIMIZE_REASON(Name, message) message,
       DEOPTIMIZE_REASON_LIST(DEOPTIMIZE_REASON)

src/deoptimize-reason.h

@@ -90,7 +90,7 @@ std::ostream& operator<<(std::ostream&, DeoptimizeReason);
 
 size_t hash_value(DeoptimizeReason reason);
 
-char const* DeoptimizeReasonToString(DeoptimizeReason reason);
+char const* const DeoptimizeReasonToString(DeoptimizeReason reason);
 
 }  // namespace internal
 }  // namespace v8

src/globals.h

@@ -912,8 +912,7 @@ inline bool IsDynamicVariableMode(VariableMode mode) {
 
 
 inline bool IsDeclaredVariableMode(VariableMode mode) {
-  STATIC_ASSERT(VAR == 0);  // Implies that mode >= VAR.
-  return mode <= CONST;
+  return mode >= VAR && mode <= CONST;
 }