Fix THREAD_CPUTIME clock_time_get on Windows #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
force-pushed
the
oscar/fix-clock-time-get-windows
branch
from
737e0da to
d16ebe6
Compare
This was referenced Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phated and I found that
clock_time_geton Windows would returnBad file descriptorwhen asking for the thread time on Windows, i.e.uvwasi_clock_time_getforUVWASI_CLOCK_THREAD_CPUTIME_ID.I saw it was just because
GetProcessTimeswas being called for both processes and threads, but threads specifically needGetThreadTimes.I added some basic smoke tests (just ensuring the calls don't fail and that the returned times are non-zero), and tested this on a Windows machine and it appears to work.
Let me know if anything else is needed to get this landed 🙂