fix: dual-stack retries infinite loop #4001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
DNS interceptor
Rationale
The DNS interceptor can be stuck in an infinite loop if dual-stack is enabled and a lookup results in a network error. It is also possible for a request to retry the same family multiple times if another request is made in-between.
Changes
Retry a failed request once with dual-stack and force it to use the other ip family.
If no valid ip address is found, e.g. due to ttl timeout, no retry should be made.
Features
Bug Fixes
Breaking Changes and Deprecations
Status